DbFunction tests are missing from the Relational specification tests #12044
Labels
area-test
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
good first issue
This issue should be relatively straightforward to fix.
help wanted
This issue involves technologies where we are not experts. Expert help would be appreciated.
providers-beware
type-bug
Milestone
Comments
|
I can do this if @divega signs off that it is something we want to do. |
|
@pmiddleton Yes, a PR for this would be good. |
ajcvickers
added
help wanted
|
@ajcvickers Do the Oracle tests run as part of the automated build? If not is there somewhere there who can verify everything passes. I don't have an Oracle setup to test on. |
8 tasks
|
@pmiddleton - They are not run as part of automated build. They are also broken at present. @ralmsdeveloper is looking into it currently. We can fix the oracle related issues while merging. |
anpete
added
the
closed-fixed
|
Fixed in 8f4faa7 |
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Jul 22, 2018
Function quoting logic was changed (for now): all function names are quoted just like any other identifier (the default EF Core behavior is only to quote schema-less functions). This meant changing all expression translators to generate lower-case names (lower() instead of LOWER()), and also to add a hardcoded list of functions which EF Core generates in upper-case but which shouldn't get quoted (e.g. SUM()). See: * dotnet/efcore#8507 * dotnet/efcore#12044 * dotnet/efcore#12757 * dotnet/efcore#9558 * dotnet/efcore#9303
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 3, 2018
Function quoting logic was changed (for now): all function names are quoted just like any other identifier (the default EF Core behavior is only to quote schema-less functions). This meant changing all expression translators to generate lower-case names (lower() instead of LOWER()), and also to add a hardcoded list of functions which EF Core generates in upper-case but which shouldn't get quoted (e.g. SUM()). See: * dotnet/efcore#8507 * dotnet/efcore#12044 * dotnet/efcore#12757 * dotnet/efcore#9558 * dotnet/efcore#9303
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 12, 2018
For now, only unquoted function names are supported (i.e. all lower- case, no special chars). Quoting logic for functions is quite complicated, see below issues for details. See: * dotnet/efcore#8507 * dotnet/efcore#12044 * dotnet/efcore#12757 * dotnet/efcore#9558 * dotnet/efcore#9303
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 12, 2018
For now, only unquoted function names are supported (i.e. all lower- case, no special chars). Quoting logic for functions is quite complicated, see below issues for details. See: * dotnet/efcore#8507 * dotnet/efcore#12044 * dotnet/efcore#12757 * dotnet/efcore#9558 * dotnet/efcore#9303
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Aug 12, 2018
For now, only unquoted function names are supported (i.e. all lower- case, no special chars). Quoting logic for functions is quite complicated, see below issues for details. See: * dotnet/efcore#8507 * dotnet/efcore#12044 * dotnet/efcore#12757 * dotnet/efcore#9558 * dotnet/efcore#9303
bricelam
added
the
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Self-explanatory -- the SQL Server and Oracle test suites have some pretty thorough UDF test classes but these are not available from the
Microsoft.EntityFrameworkCore.Relational.Specification.Testspackage. It would be nice if these were available for other providers or libraries to implement.The text was updated successfully, but these errors were encountered: