API Review fallout

Part of #20409
dotnet · Aug 6, 2020 · cf0c982 · cf0c982
1 parent b3bb4ca
commit cf0c982
Show file tree

Hide file tree

Showing 6 changed files with 81 additions and 81 deletions.
diff --git a/src/EFCore.Relational/Metadata/Builders/TableBuilder.cs b/src/EFCore.Relational/Metadata/Builders/TableBuilder.cs
@@ -35,7 +35,7 @@ public TableBuilder([NotNull] string name, [CanBeNull] string schema, [NotNull]
         /// </summary>
         /// <param name="excluded"> A value indicating whether the table should be managed by migrations. </param>
         /// <returns> The same builder instance so that multiple calls can be chained. </returns>
-        public virtual TableBuilder IsExcludedFromMigrations(bool excluded = true)
+        public virtual TableBuilder ExcludeFromMigrations(bool excluded = true)
         {
             EntityType.SetIsTableExcludedFromMigrations(excluded);
             return this;

diff --git a/src/EFCore.Relational/Metadata/Builders/TableBuilder`.cs b/src/EFCore.Relational/Metadata/Builders/TableBuilder`.cs
@@ -33,7 +33,7 @@ public TableBuilder([NotNull] string name, [CanBeNull] string schema, [NotNull]
         /// </summary>
         /// <param name="excluded"> A value indicating whether the table should be managed by migrations. </param>
         /// <returns> The same builder instance so that multiple calls can be chained. </returns>
-        public new virtual TableBuilder<TEntity> IsExcludedFromMigrations(bool excluded = true)
-            => (TableBuilder<TEntity>)base.IsExcludedFromMigrations(excluded);
+        public new virtual TableBuilder<TEntity> ExcludeFromMigrations(bool excluded = true)
+            => (TableBuilder<TEntity>)base.ExcludeFromMigrations(excluded);
     }
 }
diff --git a/src/EFCore/Metadata/Builders/IConventionEntityTypeBuilder.cs b/src/EFCore/Metadata/Builders/IConventionEntityTypeBuilder.cs
@@ -399,7 +399,7 @@ IConventionForeignKeyBuilder HasRelationship(
         ///     Configures a relationship between this and the target entity type.
         /// </summary>
         /// <param name="targetEntityType"> The entity type that this relationship targets. </param>
-        /// <param name="navigationToTargetName">
+        /// <param name="navigationName">
         ///     The name of the navigation property on this entity type that is part of the relationship.
         /// </param>
         /// <param name="setTargetAsPrincipal"> A value indicating whether the target entity type should be configured as the principal end. </param>
@@ -410,15 +410,15 @@ IConventionForeignKeyBuilder HasRelationship(
         /// </returns>
         IConventionForeignKeyBuilder HasRelationship(
             [NotNull] IConventionEntityType targetEntityType,
-            [NotNull] string navigationToTargetName,
+            [NotNull] string navigationName,
             bool setTargetAsPrincipal = false,
             bool fromDataAnnotation = false);
 
         /// <summary>
         ///     Configures a relationship between this and the target entity type.
         /// </summary>
         /// <param name="targetEntityType"> The entity type that this relationship targets. </param>
-        /// <param name="navigationToTarget"> The navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigation"> The navigation property on this entity type that is part of the relationship. </param>
         /// <param name="setTargetAsPrincipal"> A value indicating whether the target entity type should be configured as the principal end. </param>
         /// <param name="fromDataAnnotation"> Indicates whether the configuration was specified using a data annotation. </param>
         /// <returns>
@@ -427,15 +427,15 @@ IConventionForeignKeyBuilder HasRelationship(
         /// </returns>
         IConventionForeignKeyBuilder HasRelationship(
             [NotNull] IConventionEntityType targetEntityType,
-            [NotNull] MemberInfo navigationToTarget,
+            [NotNull] MemberInfo navigation,
             bool setTargetAsPrincipal = false,
             bool fromDataAnnotation = false);
 
         /// <summary>
         ///     Configures a relationship between this and the target entity type.
         /// </summary>
         /// <param name="targetEntityType"> The entity type that this relationship targets. </param>
-        /// <param name="navigationToTargetName"> The name of the navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigationName"> The name of the navigation property on this entity type that is part of the relationship. </param>
         /// <param name="inverseNavigationName">
         ///     The name of the navigation property on the target entity type that is part of the relationship. If <see langword="null" />
         ///     is specified, the relationship will be configured without a navigation property on the target end.
@@ -448,7 +448,7 @@ IConventionForeignKeyBuilder HasRelationship(
         /// </returns>
         IConventionForeignKeyBuilder HasRelationship(
             [NotNull] IConventionEntityType targetEntityType,
-            [NotNull] string navigationToTargetName,
+            [NotNull] string navigationName,
             [CanBeNull] string inverseNavigationName,
             bool setTargetAsPrincipal = false,
             bool fromDataAnnotation = false);
@@ -457,7 +457,7 @@ IConventionForeignKeyBuilder HasRelationship(
         ///     Configures a relationship between this and the target entity type.
         /// </summary>
         /// <param name="targetEntityType"> The entity type that this relationship targets. </param>
-        /// <param name="navigationToTarget"> The navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigation"> The navigation property on this entity type that is part of the relationship. </param>
         /// <param name="inverseNavigation">
         ///     The navigation property on the target entity type that is part of the relationship. If <see langword="null" />
         ///     is specified, the relationship will be configured without a navigation property on the target end.
@@ -470,7 +470,7 @@ IConventionForeignKeyBuilder HasRelationship(
         /// </returns>
         IConventionForeignKeyBuilder HasRelationship(
             [NotNull] IConventionEntityType targetEntityType,
-            [NotNull] MemberInfo navigationToTarget,
+            [NotNull] MemberInfo navigation,
             [CanBeNull] MemberInfo inverseNavigation,
             bool setTargetAsPrincipal = false,
             bool fromDataAnnotation = false);
@@ -479,34 +479,34 @@ IConventionForeignKeyBuilder HasRelationship(
         ///     Configures a relationship where the target entity is owned by (or part of) this entity.
         /// </summary>
         /// <param name="targetEntityType"> The type that this relationship targets. </param>
-        /// <param name="navigationToTargetName"> The name of the navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigationName"> The name of the navigation property on this entity type that is part of the relationship. </param>
         /// <param name="fromDataAnnotation"> Indicates whether the configuration was specified using a data annotation. </param>
         /// <returns> An object that can be used to configure the relationship. </returns>
         IConventionForeignKeyBuilder HasOwnership(
             [NotNull] Type targetEntityType,
-            [NotNull] string navigationToTargetName,
+            [NotNull] string navigationName,
             bool fromDataAnnotation = false);
 
         /// <summary>
         ///     Configures a relationship where the target entity is owned by (or part of) this entity.
         /// </summary>
         /// <param name="targetEntityType"> The type that this relationship targets. </param>
-        /// <param name="navigationToTarget"> The navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigation"> The navigation property on this entity type that is part of the relationship. </param>
         /// <param name="fromDataAnnotation"> Indicates whether the configuration was specified using a data annotation. </param>
         /// <returns>
         ///     An object that can be used to configure the relationship if it exists on the entity type,
         ///     <see langword="null" /> otherwise.
         /// </returns>
         IConventionForeignKeyBuilder HasOwnership(
             [NotNull] Type targetEntityType,
-            [NotNull] MemberInfo navigationToTarget,
+            [NotNull] MemberInfo navigation,
             bool fromDataAnnotation = false);
 
         /// <summary>
         ///     Configures a relationship where the target entity is owned by (or part of) this entity.
         /// </summary>
         /// <param name="targetEntityType"> The type that this relationship targets. </param>
-        /// <param name="navigationToTargetName"> The name of the navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigationName"> The name of the navigation property on this entity type that is part of the relationship. </param>
         /// <param name="inverseNavigationName">
         ///     The name of the navigation property on the target entity type that is part of the relationship. If <see langword="null" />
         ///     is specified, the relationship will be configured without a navigation property on the target end.
@@ -518,15 +518,15 @@ IConventionForeignKeyBuilder HasOwnership(
         /// </returns>
         IConventionForeignKeyBuilder HasOwnership(
             [NotNull] Type targetEntityType,
-            [NotNull] string navigationToTargetName,
+            [NotNull] string navigationName,
             [CanBeNull] string inverseNavigationName,
             bool fromDataAnnotation = false);
 
         /// <summary>
         ///     Configures a relationship where the target entity is owned by (or part of) this entity.
         /// </summary>
         /// <param name="targetEntityType"> The type that this relationship targets. </param>
-        /// <param name="navigationToTarget"> The navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigation"> The navigation property on this entity type that is part of the relationship. </param>
         /// <param name="inverseNavigation">
         ///     The navigation property on the target entity type that is part of the relationship. If <see langword="null" />
         ///     is specified, the relationship will be configured without a navigation property on the target end.
@@ -538,7 +538,7 @@ IConventionForeignKeyBuilder HasOwnership(
         /// </returns>
         IConventionForeignKeyBuilder HasOwnership(
             [NotNull] Type targetEntityType,
-            [NotNull] MemberInfo navigationToTarget,
+            [NotNull] MemberInfo navigation,
             [CanBeNull] MemberInfo inverseNavigation,
             bool fromDataAnnotation = false);
 
@@ -631,7 +631,7 @@ bool CanAddNavigation([NotNull] string navigationName, bool fromDataAnnotation =
         ///     Configures a skip navigation and the inverse between this and the target entity type.
         /// </summary>
         /// <param name="targetEntityType"> The entity type that this relationship targets. </param>
-        /// <param name="navigationToTarget"> The navigation property on this entity type that is part of the relationship. </param>
+        /// <param name="navigation"> The navigation property on this entity type that is part of the relationship. </param>
         /// <param name="inverseNavigation">
         ///     The navigation property on the target entity type that is part of the relationship. If <see langword="null" />
         ///     is specified, the relationship will be configured without a navigation property on the target end.
@@ -646,7 +646,7 @@ bool CanAddNavigation([NotNull] string navigationName, bool fromDataAnnotation =
         ///     <see langword="null" /> otherwise.
         /// </returns>
         IConventionSkipNavigationBuilder HasSkipNavigation(
-            [NotNull] MemberInfo navigationToTarget,
+            [NotNull] MemberInfo navigation,
             [NotNull] IConventionEntityType targetEntityType,
             [NotNull] MemberInfo inverseNavigation,
             bool? collections = null,
@@ -656,7 +656,7 @@ IConventionSkipNavigationBuilder HasSkipNavigation(
         /// <summary>
         ///     Configures a skip navigation between this and the target entity type.
         /// </summary>
-        /// <param name="navigationToTarget"> The navigation property. </param>
+        /// <param name="navigation"> The navigation property. </param>
         /// <param name="targetEntityType"> The entity type that the navigation targets. </param>
         /// <param name="collection"> Whether the navigation property is a collection property. </param>
         /// <param name="onDependent">
@@ -668,7 +668,7 @@ IConventionSkipNavigationBuilder HasSkipNavigation(
         ///     <see langword="null" /> otherwise.
         /// </returns>
         IConventionSkipNavigationBuilder HasSkipNavigation(
-            [NotNull] MemberInfo navigationToTarget,
+            [NotNull] MemberInfo navigation,
             [NotNull] IConventionEntityType targetEntityType,
             bool? collection = null,
             bool? onDependent = null,