Allow DI for pooled DbContexts (#30739)

Co-authored-by: Steven.Darby <[email protected]>
dotnet · Apr 21, 2023 · b35364d · b35364d
1 parent 0adaa62
commit b35364d
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 18 deletions.
diff --git a/src/EFCore/Internal/DbContextPool.cs b/src/EFCore/Internal/DbContextPool.cs
@@ -35,7 +35,7 @@ public class DbContextPool<TContext> : IDbContextPool<TContext>, IDisposable, IA
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    public DbContextPool(DbContextOptions<TContext> options)
+    public DbContextPool(DbContextOptions<TContext> options, IServiceProvider? serviceProvider = default)
     {
         _maxSize = options.FindExtension<CoreOptionsExtension>()?.MaxPoolSize ?? DefaultPoolSize;
 
@@ -46,23 +46,29 @@ public DbContextPool(DbContextOptions<TContext> options)
 
         options.Freeze();
 
-        _activator = CreateActivator(options);
+        _activator = CreateActivator(options, serviceProvider);
     }
 
-    private static Func<DbContext> CreateActivator(DbContextOptions<TContext> options)
+    private static Func<DbContext> CreateActivator(DbContextOptions<TContext> options, IServiceProvider? serviceProvider)
     {
         var constructors = typeof(TContext).GetTypeInfo().DeclaredConstructors
             .Where(c => !c.IsStatic && c.IsPublic && c.GetParameters().Length > 0).ToArray();
 
-        if (constructors.Length == 1)
+        if (constructors.Length == 1
+            && constructors[0].GetParameters() is { } parameters
+            && parameters.Any(p => p.ParameterType == typeof(DbContextOptions) || p.ParameterType == typeof(DbContextOptions<TContext>)))
         {
-            var parameters = constructors[0].GetParameters();
-            if (parameters.Length == 1
-                && (parameters[0].ParameterType == typeof(DbContextOptions)
-                    || parameters[0].ParameterType == typeof(DbContextOptions<TContext>)))
+            if (parameters.Length == 1)
             {
                 return Expression.Lambda<Func<TContext>>(Expression.New(constructors[0], Expression.Constant(options))).Compile();
             }
+
+            if (serviceProvider is not null)
+            {
+                var factory = ActivatorUtilities.CreateFactory<TContext>(new[] { typeof(DbContextOptions<TContext>) });
+                var activatorParameters = new object[] { options };
+                return () => factory.Invoke(serviceProvider, activatorParameters);
+            }
         }
 
         throw new InvalidOperationException(CoreStrings.PoolingContextCtorError(typeof(TContext).ShortDisplayName()));

diff --git a/src/EFCore/Properties/CoreStrings.Designer.cs b/src/EFCore/Properties/CoreStrings.Designer.cs
diff --git a/test/EFCore.SqlServer.FunctionalTests/DbContextPoolingTest.cs b/test/EFCore.SqlServer.FunctionalTests/DbContextPoolingTest.cs
@@ -454,40 +454,38 @@ public void Throws_when_used_with_parameterless_constructor_context()
     }
 
     [ConditionalFact]
-    public void Throws_when_pooled_context_constructor_has_more_than_one_parameter()
+    public void Throws_when_pooled_context_constructor_has_second_parameter_that_cannot_be_resolved_from_service_provider()
     {
         var serviceProvider
             = new ServiceCollection().AddDbContextPool<TwoParameterConstructorContext>(_ => { })
                 .BuildServiceProvider(validateScopes: true);
 
         using var scope = serviceProvider.CreateScope();
 
-        Assert.Equal(
-            CoreStrings.PoolingContextCtorError(nameof(TwoParameterConstructorContext)),
-            Assert.Throws<InvalidOperationException>(() => scope.ServiceProvider.GetService<TwoParameterConstructorContext>()).Message);
+        Assert.Throws<InvalidOperationException>(() => scope.ServiceProvider.GetService<TwoParameterConstructorContext>());
     }
 
     private class TwoParameterConstructorContext : DbContext
     {
+        public string StringParameter { get; }
+
         public TwoParameterConstructorContext(DbContextOptions options, string x)
             : base(options)
         {
+            StringParameter = x;
         }
     }
 
     [ConditionalFact]
-    public void Throws_when_pooled_context_constructor_wrong_parameter()
+    public void Throws_when_pooled_context_constructor_has_single_parameter_that_cannot_be_resolved_from_service_provider()
     {
         var serviceProvider
             = new ServiceCollection().AddDbContextPool<WrongParameterConstructorContext>(_ => { })
                 .BuildServiceProvider(validateScopes: true);
 
         using var scope = serviceProvider.CreateScope();
 
-        Assert.Equal(
-            CoreStrings.PoolingContextCtorError(nameof(WrongParameterConstructorContext)),
-            Assert.Throws<InvalidOperationException>(() => scope.ServiceProvider.GetService<WrongParameterConstructorContext>())
-                .Message);
+        Assert.Throws<InvalidOperationException>(() => scope.ServiceProvider.GetService<WrongParameterConstructorContext>());
     }
 
     private class WrongParameterConstructorContext : DbContext
@@ -498,6 +496,35 @@ public WrongParameterConstructorContext(string x)
         }
     }
 
+    [ConditionalFact]
+    public void Throws_when_pooled_context_constructor_has_scoped_service()
+    {
+        var serviceProvider
+            = new ServiceCollection()
+                .AddDbContextPool<TwoParameterConstructorContext>(_ => { })
+                .AddScoped(sp => "string")
+                .BuildServiceProvider(validateScopes: true);
+
+        using var scope = serviceProvider.CreateScope();
+
+        Assert.Throws<InvalidOperationException>(() => scope.ServiceProvider.GetService<TwoParameterConstructorContext>());
+    }
+
+    [ConditionalFact]
+    public void Does_not_throw_when_pooled_context_constructor_has_singleton_service()
+    {
+        var serviceProvider
+            = new ServiceCollection()
+                .AddDbContextPool<TwoParameterConstructorContext>(_ => { })
+                .AddSingleton("string")
+                .BuildServiceProvider(validateScopes: true);
+
+        using var scope = serviceProvider.CreateScope();
+        var context = scope.ServiceProvider.GetService<TwoParameterConstructorContext>();
+
+        Assert.Equal("string", context.StringParameter);
+    }
+
     [ConditionalFact]
     public void Does_not_throw_when_parameterless_and_correct_constructor()
     {