Skip to content

Commit

Permalink
Query: Correct tracking issue number for tests referencing closed issues
Browse files Browse the repository at this point in the history
  • Loading branch information
smitpatel committed Aug 13, 2019
1 parent 40bcd6c commit ab44b00
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2822,7 +2822,7 @@ public virtual Task Multiple_required_navigation_using_multiple_selects_with_Inc
elementSorter: e => e.Id);
}

[ConditionalTheory(Skip = "Issue#16090")]
[ConditionalTheory(Skip = "Issue#16752")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Multiple_required_navigation_with_string_based_Include(bool isAsync)
{
Expand All @@ -2838,7 +2838,7 @@ public virtual Task Multiple_required_navigation_with_string_based_Include(bool
elementSorter: e => e.Id);
}

[ConditionalTheory(Skip = "Issue#16090")]
[ConditionalTheory(Skip = "Issue#16752")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Multiple_required_navigation_using_multiple_selects_with_string_based_Include(bool isAsync)
{
Expand Down Expand Up @@ -2909,7 +2909,7 @@ public virtual Task Multiple_optional_navigation_with_Include(bool isAsync)
elementSorter: e => e != null ? e.Id : 0);
}

[ConditionalTheory(Skip = "Issue#16090")]
[ConditionalTheory(Skip = "Issue#16752")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Multiple_optional_navigation_with_string_based_Include(bool isAsync)
{
Expand Down
10 changes: 5 additions & 5 deletions test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5668,7 +5668,7 @@ where MaybeScalar(h, () => h.Eradicated) != true
select h);
}

[ConditionalFact(Skip = "Issue #10974")]
[ConditionalFact(Skip = "Issue #17068")]
public virtual void Include_collection_group_by_reference()
{
using (var context = CreateContext())
Expand Down Expand Up @@ -5860,7 +5860,7 @@ public virtual Task Negated_bool_ternary_inside_anonymous_type_in_projection(boo
elementSorter: e => e.c);
}

[ConditionalTheory(Skip = "Issue #15848")]
[ConditionalTheory(Skip = "Issue #17109")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Order_by_entity_qsre(bool isAsync)
{
Expand All @@ -5872,7 +5872,7 @@ public virtual Task Order_by_entity_qsre(bool isAsync)
assertOrder: true);
}

[ConditionalTheory(Skip = "Issue #15848")]
[ConditionalTheory(Skip = "Issue #17109")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Order_by_entity_qsre_with_inheritance(bool isAsync)
{
Expand All @@ -5882,7 +5882,7 @@ public virtual Task Order_by_entity_qsre_with_inheritance(bool isAsync)
assertOrder: true);
}

[ConditionalTheory(Skip = "Issue #15848")]
[ConditionalTheory(Skip = "Issue #17109")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Order_by_entity_qsre_composite_key(bool isAsync)
{
Expand All @@ -5894,7 +5894,7 @@ public virtual Task Order_by_entity_qsre_composite_key(bool isAsync)
assertOrder: true);
}

[ConditionalTheory(Skip = "Issue #15848")]
[ConditionalTheory(Skip = "Issue #17109")]
[MemberData(nameof(IsAsyncData))]
public virtual Task Order_by_entity_qsre_with_other_orderbys(bool isAsync)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public virtual void Extension_method_DbContext_property_chain_is_parameterized()
}
}

[ConditionalFact(Skip = "See issue#13587")]
[ConditionalFact(Skip = "See issue#17111")]
public virtual void Using_DbSet_in_filter_works()
{
using (var context = CreateContext())
Expand All @@ -339,7 +339,7 @@ public virtual void Using_DbSet_in_filter_works()
}
}

[ConditionalFact(Skip = "See issue#13587")]
[ConditionalFact(Skip = "See issue#17111")]
public virtual void Using_Context_set_method_in_filter_works()
{
using (var context = CreateContext())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5314,7 +5314,7 @@ public class AddressTurnovers13157

#region Bug13346

[ConditionalFact(Skip = "Issue #13346")]
[ConditionalFact(Skip = "Issue #16323")]
public virtual void ToQuery_can_define_in_own_terms_using_FromSql()
{
using (CreateDatabase13346())
Expand Down

0 comments on commit ab44b00

Please sign in to comment.