Fix for 17509. Do not allow migration to have same name as context. (#…

…20143)
dotnet · Mar 3, 2020 · 3197d54 · 3197d54
1 parent e36b86f
commit 3197d54
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/EFCore.Design/Design/Internal/MigrationsOperations.cs b/src/EFCore.Design/Design/Internal/MigrationsOperations.cs
@@ -90,6 +90,13 @@ public virtual MigrationFiles AddMigration(
             var subNamespace = SubnamespaceFromOutputPath(outputDir);
 
             using var context = _contextOperations.CreateContext(contextType);
+            var contextClassName = context.GetType().Name;
+            if (string.Equals(name, contextClassName, StringComparison.Ordinal))
+            {
+                throw new OperationException(
+                    DesignStrings.ConflictingContextAndMigrationName(name));
+            }
+
             var services = _servicesBuilder.Build(context);
             EnsureServices(services);
             EnsureMigrationsAssembly(services);

diff --git a/src/EFCore.Design/Properties/DesignStrings.Designer.cs b/src/EFCore.Design/Properties/DesignStrings.Designer.cs
diff --git a/src/EFCore.Design/Properties/DesignStrings.resx b/src/EFCore.Design/Properties/DesignStrings.resx
@@ -363,4 +363,7 @@ Change your target project to the migrations project by using the Package Manage
   <data name="UnhandledEnumValue" xml:space="preserve">
     <value>Unhandled enum value '{enumValue}'.</value>
   </data>
+  <data name="ConflictingContextAndMigrationName" xml:space="preserve">
+    <value>The name you have chosen for the migration, '{name}', is the same as the context class name. Please choose a different name for your migration. Might we suggest 'InitialCreate' for your first migration?</value>
+  </data>
 </root>