Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #860 #899

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Fix #860 #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EntityFramework/Core/Objects/ELinq/QueryParameterExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ internal object EvaluateParameter(object[] arguments)
// </summary>
internal QueryParameterExpression EscapeParameterForLike(Expression<Func<string, Tuple<string, bool>>> method)
{
Expression wrappedExpression = Expression.Property(Invoke(Constant(method), _funcletizedExpression), "Item1");
Expression wrappedExpression = Expression.Property(Invoke(method, _funcletizedExpression), "Item1");
return new QueryParameterExpression(_parameterReference, wrappedExpression, _compiledQueryParameters);
}

Expand Down
6 changes: 1 addition & 5 deletions test/EntityFramework/FunctionalTests/Query/CompiledQuery/CompiledQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,7 @@ private CompiledQueryContext CreateCompiledQueryContext()
return ctx;
}

[Fact(
#if NETCOREAPP3_0
Skip = "#860"
#endif
)]
[Fact]
public void CompiledQuery_with_contains_does_not_hold_reference_to_context()
{
WeakReference wr;
Expand Down