Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce null semantics for >, >=, <, and <= in plan compiler. #466

Closed
wants to merge 1 commit into from
Closed

Enforce null semantics for >, >=, <, and <= in plan compiler. #466

wants to merge 1 commit into from

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Feb 14, 2018

ported from CodePlex

@maumar maumar mentioned this pull request Feb 14, 2018
Closed
@ajcvickers
Copy link
Contributor

@divega What are your thoughts on changing this in EF6. Wouldn't it break any apps that are relying on this behavior not being present for these operators?

@ajcvickers
Copy link
Contributor

@divega Talked to @maumar about this and we agreed that these changes are not correct, specifically in negation. Given this is likely a breaking change even if done right I am going to close this for now. We can always revisit if there is interest.

@ajcvickers ajcvickers closed this Aug 15, 2018
@smitpatel smitpatel deleted the ComparisonNullSemantics branch August 31, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maumar @ajcvickers @divega @brandondahler