Use async DiagnosticsClient APIs #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktork
approved these changes
Aug 27, 2021
jander-msft
force-pushed
the
dev/jander/diagnostics-client-async
branch
from
5b53c6d to
8d06a15
Compare
|
/azp run dotnet-monitor-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
jander-msft
added a commit
that referenced
this pull request
Sep 3, 2021
* Add live metrics api (#750) * Add live metrics api * Fix invalid metric value * PR Feedback * Rename livemetrics to collectmetrics * Use async DiagnosticsClient APIs. (#790) * Update dependencies from https://github.com/dotnet/diagnostics build 20210902.1 (#819) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/aspnetcore build 20210903.2 (#822) VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21452.1 -> To Version 6.0.0-rc.2.21453.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/runtime build 20210902.24 (#821) VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.2.21452.2 -> To Version 6.0.0-rc.2.21452.24 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20210902.4 (#820) Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.21451.3 -> To Version 7.0.0-beta.21452.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Consolidate task and completion source cancellation methods. (#818) Add TaskCompletionSourceExtensions to dotnet-monitor. Move WithCancellation extension method to dotnet-monitor. * Documentation for metrics (#815) Also fixup some examples for Bearer Co-authored-by: Wiktor Kopec <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes rely on the following PR from the diagnostics repo: dotnet/diagnostics#2350
These changes only switch to using the async APIs on the DiagnosticsClient class. Subsequent changes to timeout on querying the process list will be made in a different PR.