Add callback interface to IEndpointInfoSource implementations #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelltrick
approved these changes
Aug 23, 2021
src/Tools/dotnet-monitor/EndpointInfo/EndpointInfoExtensions.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/EndpointInfoSourceTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTests/EndpointInfoSourceTests.cs
Show resolved
Hide resolved
jander-msft
added a commit
that referenced
this pull request
Aug 24, 2021
* Update dependencies from https://github.com/dotnet/arcade build 20210817.1 (#733) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/aspnetcore build 20210817.14 (#735) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/runtime build 20210817.16 (#734) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/diagnostics build 20210817.1 (#732) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/diagnostics build 20210818.1 (#739) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/arcade build 20210818.12 (#740) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/aspnetcore build 20210818.11 (#741) [main] Update dependencies from dotnet/aspnetcore * Add release notes (#738) * Add release notes to project * Add README.md and template for release notes * Update dependencies from https://github.com/dotnet/arcade build 20210819.2 (#745) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/diagnostics build 20210819.1 (#744) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/runtime build 20210820.4 (#746) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210819.24 (#747) [main] Update dependencies from dotnet/aspnetcore * Archive release notes from preview 6, reset releaseNotes.md for post preview 7 snap (#749) * Update dependencies from https://github.com/dotnet/diagnostics build 20210820.1 (#752) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/runtime build 20210820.29 (#754) [main] Update dependencies from dotnet/runtime * Update dependencies from https://github.com/dotnet/aspnetcore build 20210820.26 (#755) [main] Update dependencies from dotnet/aspnetcore * Update dependencies from https://github.com/dotnet/aspnetcore build 20210821.2 (#756) [main] Update dependencies from dotnet/aspnetcore * Update main to Preview 8 (#751) * Change call to UseApiKey to match pattern used elsewhere in Tests code (#757) * Add release notes for preview 7 canidate build to main (#758) * Update dependencies from https://github.com/dotnet/arcade build 20210820.4 (#753) [main] Update dependencies from dotnet/arcade * Add callback interface to IEndpointInfoSource implementations (#743) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Patrick Fenelon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the derived ServerEndpointInfoSource in tests to a callback system which will allow other systems to participate in IEndpointInfoSource changes. For example, other systems can now configure a newly discovered process within the system before the process's runtime is resumed.