Generate action and trigger options in schema. #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jander-msft
commented
Aug 11, 2021
jander-msft
commented
- Generate action and trigger options in schema.
- Add display name descriptions to these options.
- Add defaults for the optional properties.
- Other small changes such as property renames and changing IncludePaths and ExcludePaths property to arrays.
Add display name descriptions to these options. Add defaults for the optional properties.
kkeirstead
reviewed
Aug 11, 2021
src/Microsoft.Diagnostics.Monitoring.Options/OptionsDisplayStrings.resx
Outdated
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 11, 2021
src/Tests/Microsoft.Diagnostics.Monitoring.ConfigurationSchema/SchemaGenerator.cs
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 11, 2021
src/Tools/dotnet-monitor/CollectionRules/Options/Triggers/AspNetRequestCountOptionsDefaults.cs
Outdated
Show resolved
Hide resolved
kelltrick
approved these changes
Aug 12, 2021
| { | ||
| public const int MetricsIntervalSeconds = 1; | ||
| public const bool RequestRundown = true; | ||
| public const int BufferSizeMegabytes = 256; |
There was a problem hiding this comment.
This seems like a big constant given our recommended container limits. Does this buffer not end up in our memory?
There was a problem hiding this comment.
This is the existing default when doing a trace, but I agree. I think we need to adjust these downward a bit.
The buffer ends up in the memory of the target application. It's the size of the buffer that events are put into just before the diagnostic server pulls them out and sends them over the event pipe. If an event source cannot put a new event into the buffer due to running out of room, the event is dropped relatively silently. This makes code that is listening for a start and stop event interesting because it has to guess whether the stop event just hasn't come through yet or was dropped.
src/Tools/dotnet-monitor/CollectionRules/Options/Triggers/AspNetResponseStatusOptions.cs
Show resolved
Hide resolved
jander-msft
added a commit
that referenced
this pull request
Sep 17, 2021
* Initial collection rule options, validation, and unit tests. (#688) * Generate action and trigger options in schema. (#706) Generate action and trigger options in schema. Add display name descriptions to these options. Add defaults for the optional properties. * Create `Execute` collection rule action (#710) * Basic implementation and registration of actions and triggers (#736) Initial interfaces for collection rule triggers. Implement empty action and trigger implementations. Implement startup trigger with special interface denoting it is a startup trigger. Rename action provider and trigger provider to descriptor. Register action and trigger implementations with descriptors. * Execute Action - Testing (#742) * Update trigger interfaces with callback, start, and stop notions. (#760) Update trigger interfaces with callback, start, and stop notions. Refactor options providers into operations implementations. * Refactor host building into helper method (#769) * Refactor host building into helper method. * Triggers - Action List Executor (#768) * Implement collection rule pipeline, event counter trigger, and tests. (#825) Implement collection rule pipeline and event counter trigger. Add tests for collection rule pipeline with real and test triggers and actions. * Create CollectDump Collection Rule Action (#824) * Fix CollectionRulePipelineTests failure due to callback registration timing. (#854) * Collection rule service, logging, and some functional tests (#852) * Implement collection rule service for starting rules. Add logging throughout collection rule system. Add some functional tests for collection rule system. * Refactor common parameters into CollectionRuleContext. * Add safe cancellation. * Add collection rule completion timeouts. * Refactor logging event IDs into separate shareable class. * Adjust temporary directory creation and log cleanup failures. * Remove CollectionRulePipeline.StartAsync; replace with callback. Add safe awaiting for start tasks and run tasks. Add more logging and adjust some log levels. * Replace TestCommon dependency with Xunit.Assert (#874) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: kkeirstead <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Wiktor Kopec <[email protected]> Co-authored-by: Patrick Fenelon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.