Refactor schema gen to generically create discriminated subschemas #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkeirstead
reviewed
Aug 10, 2021
src/Tests/Microsoft.Diagnostics.Monitoring.ConfigurationSchema/SchemaGenerator.cs
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 10, 2021
src/Tests/Microsoft.Diagnostics.Monitoring.ConfigurationSchema/SchemaGenerator.cs
Outdated
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 10, 2021
src/Tests/Microsoft.Diagnostics.Monitoring.ConfigurationSchema/SchemaGenerator.cs
Show resolved
Hide resolved
kkeirstead
reviewed
Aug 10, 2021
src/Tests/Microsoft.Diagnostics.Monitoring.ConfigurationSchema/SchemaGenerator.cs
Outdated
Show resolved
Hide resolved
kkeirstead
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
I think this is everything I noticed when going over the PR, so I can Approve this, but if you want to get another set of eyes on it before merging maybe @kelltrick can look over it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows adding more discriminated subschemas in the future without reimplementing the concept for each set of options. Also, generate schemas from type information and cache it in a resolver so that type schemas can be reused across multiple type generations.