Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test assemblies and namespaces. #670

Merged

Conversation

jander-msft
Copy link
Member

Renamed test assemblies and namespaces to better reflect which assemblies and what aspects they are testing.

Renamed Microsoft.Diagnostics.Monitoring.Tool.UnitTests assembly to Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests
Renamed Microsoft.Diagnostics.Monitoring.UnitTests assembly to Microsoft.Diagnostics.Monitoring.WebApi.UnitTests
Renamed namespaces to correspond with test assemblies.

Renamed Microsoft.Diagnostics.Monitoring.Tool.UnitTests assembly to Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests
Renamed Microsoft.Diagnostics.Monitoring.UnitTests assembly to Microsoft.Diagnostics.Monitoring.WebApi.UnitTests
Renamed namespaces to correspond with test assemblies.
@jander-msft jander-msft requested a review from a team as a code owner August 2, 2021 20:25
@wiktork
Copy link
Member

wiktork commented Aug 2, 2021

Do we have any readme that reflects the desire to keep the functional unit test assembly separated from the rest of the assembly graph? It may be worth documenting this if we haven't already.

@jander-msft
Copy link
Member Author

Do we have any readme that reflects the desire to keep the functional unit test assembly separated from the rest of the assembly graph? It may be worth documenting this if we haven't already.

I've made an issue to document the testing strategy: #671

@jander-msft
Copy link
Member Author

AzDO is not propagating build results back to GitHub at this time. Since the build completed successfully, I'm going to bypass the build gate.

@jander-msft jander-msft merged commit 18236e0 into dotnet:main Aug 2, 2021
@jander-msft jander-msft deleted the dev/jander/test-assembly-rename branch August 2, 2021 22:27
jander-msft added a commit that referenced this pull request Aug 2, 2021
* Update dependencies from https://github.com/dotnet/diagnostics build 20210730.1 (#662)

[main] Update dependencies from dotnet/diagnostics

* Update dependencies from https://github.com/dotnet/runtime build 20210730.13 (#663)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/runtime build 20210801.1 (#666)

[main] Update dependencies from dotnet/runtime

* [main] Update dependencies from dotnet/aspnetcore (#664)

[main] Update dependencies from dotnet/aspnetcore

* Update dependencies from https://github.com/dotnet/runtime build 20210801.3 (#667)

[main] Update dependencies from dotnet/runtime

* Disable http response egress - testing (#637)

* Rename test assemblies and namespaces. (#670)

Renamed Microsoft.Diagnostics.Monitoring.Tool.UnitTests assembly to Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests
Renamed Microsoft.Diagnostics.Monitoring.UnitTests assembly to Microsoft.Diagnostics.Monitoring.WebApi.UnitTests
Renamed namespaces to correspond with test assemblies.

Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: kkeirstead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants