[release/7.x] Port System.Diagnostics.Metrics #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add prototype support for system diagnostics metrics * [feature branch, do not review] Update counter api, fixup metadata parsing (dotnet#3137) * Fix ICountersLogger contract * MetadataUpdates * Fixup merge issues * Fixup api protection levels * Fixup tests and add CounterEnded payload * Fixup metadata parsing * [System Diagnostics Metrics] Quantile->Percentile Changes & Testing Improvements (dotnet#3165) * Rename counterpipeline * Fix invariant * Fixup regex * Added tests for histogram and timeseries; addressed some other feedback. Still need to address erroneusly printing error message when doing live metrics without Sys.Diag.Metrics, and add configuration option to allow users to specify eventcounter/sys.diag.metrics * Fix counter name * Use one payload for Histogram * Added MetricType option for configuration; added testing to go along with it * Move documentation to correct file * Initial PR feedback * Do not allow CounterEnded events to displace existing metrics * Deduplicate errors * Update dependencies from https://github.com/dotnet/diagnostics build 20230130.1 Microsoft.Diagnostics.Monitoring , Microsoft.Diagnostics.Monitoring.EventPipe From Version 6.0.0-preview.23077.1 -> To Version 6.0.0-preview.23080.1 * Fix minor formatting issues * Fix spell check issues * Update documentation/configuration/metrics-configuration.md Co-authored-by: Justin Anderson <[email protected]> * Update documentation/configuration/metrics-configuration.md Co-authored-by: Justin Anderson <[email protected]> * PR Feedback * Add comment from PR --------- Co-authored-by: kkeirstead <[email protected]> Co-authored-by: kkeirstead <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Justin Anderson <[email protected]>
* Fix quantile issue for summaries * Fix unit test * Fixup labels
wiktork
commented
Feb 22, 2023
jander-msft
previously approved these changes
Feb 22, 2023
jander-msft
added
the
backport
jander-msft
previously approved these changes
Feb 22, 2023
jander-msft
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport #3479 to
release/7.xRelease Notes Entry