[Egress Extensibility] Convert S3 to An Egress Extension (Pt 1) #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it actually works yet.
…ub.com/kkeirstead/dotnet-monitor into kkeirstead/egressExtension_S3Extension
…le to successfully egress using the extension.
jander-msft
reviewed
Feb 17, 2023
jander-msft
reviewed
Feb 17, 2023
jander-msft
reviewed
Feb 22, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressProviderOptions.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/SharedEntrypoint.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/SharedEntrypoint.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/Utilities.cs
Outdated
Show resolved
Hide resolved
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/SharedEntrypoint.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Feb 23, 2023
jander-msft
reviewed
Feb 23, 2023
...nostics.Monitoring.Extension.Common/Microsoft.Diagnostics.Monitoring.Extension.Common.csproj
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Feb 23, 2023
...nostics.Monitoring.Extension.Common/Microsoft.Diagnostics.Monitoring.Extension.Common.csproj
Show resolved
Hide resolved
jander-msft
reviewed
Feb 23, 2023
...nostics.Monitoring.Extension.Common/Microsoft.Diagnostics.Monitoring.Extension.Common.csproj
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Feb 23, 2023
...nostics.Monitoring.Extension.Common/Microsoft.Diagnostics.Monitoring.Extension.Common.csproj
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Feb 23, 2023
jander-msft
reviewed
Feb 23, 2023
jander-msft
approved these changes
Feb 24, 2023
wiktork
reviewed
Feb 24, 2023
wiktork
reviewed
Feb 24, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Show resolved
Hide resolved
wiktork
reviewed
Feb 24, 2023
wiktork
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first part of converting the S3 egress functionality into an extension (similar to how Azure Blob Storage is currently set up in this feature branch). For the most part, there is no "new" code here - portions of the code have been transferred from the core product to an extension, and other supporting files have been copied from the Azure extension.
At this time, this extension does not have the fixes for #3642 #3643 #3644 and thus is not fully functional. Currently, the plan is for the fixes for these issues to be ported over to this branch after being made first in
main. Using the workarounds specified in the aforementioned issues, this extension can egress artifacts to S3 storage.Future work that still needs to be done around this extension includes:
Release Notes Entry