-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial stab at creating swagger for dotnet-monitor #3241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File is now embedded in resources of app so that we don't need to have a wwwroot hanging around. Created a controller to deliver that file. Added authentication info so you can paste a JWT token into the UI to be able to call in authenticated scenarios
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wiktork
reviewed
Jan 17, 2023
src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/SwaggerFilesController.cs
Show resolved
Hide resolved
wiktork
previously approved these changes
Jan 17, 2023
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/HttpApi/ApiClientExtensions.cs
Outdated
Show resolved
Hide resolved
…s/HttpApi/ApiClientExtensions.cs Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jander-msft
approved these changes
Jan 18, 2023
schmittjoseph
added
the
update-release-notes
Pull requests that should be mentioned in the release notes
label
Jan 18, 2023
/backport to release/7.x |
Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/4001350056 |
github-actions bot
added a commit
that referenced
this pull request
Jan 24, 2023
Co-authored-by: Sam Spencer <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Justin Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds swagger UI to dotnet-monitor as the default endpoint. That helps by giving you documentation of the endpoint, and also the ability to use it.
Issues
Release Notes Entry
Add Swagger UI to dotnet-monitor as the default endpoint. This will provide documentation of endpoints, and also the ability to use them.