Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tags for API Requests #2919

Merged
merged 17 commits into from
Dec 2, 2022
Merged

Add Tags for API Requests #2919

merged 17 commits into from
Dec 2, 2022

Conversation

kkeirstead
Copy link
Member

Summary

This change allows users to add a tag to an operation to make it easier to identify when looking at the operations table.

Closes #2783

Release Notes Entry

Add Tags For API Requests

@kkeirstead kkeirstead added the update-release-notes Pull requests that should be mentioned in the release notes label Nov 21, 2022
@kkeirstead kkeirstead requested a review from a team as a code owner November 21, 2022 16:56
wiktork
wiktork previously approved these changes Nov 22, 2022
View reviewed changes
@jander-msft
Copy link
Member

Consider a design where an operation has a tags property that is an array of string so that it can be future proof for having multiple tags, even if it only has zero or one entries in it for now.

wiktork
wiktork previously approved these changes Nov 29, 2022
View reviewed changes
jander-msft
jander-msft previously approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@jander-msft jander-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that we don't want to allow commas to be part of a tag, then this looks good to me.

@kkeirstead kkeirstead dismissed stale reviews from jander-msft and wiktork via 2c09cd8 November 30, 2022 21:17
@kkeirstead kkeirstead merged commit 506cee2 into dotnet:main Dec 2, 2022
@jander-msft jander-msft added servicing-minor Servicing fixes that is targeted for a minor release (0.x.0 version) servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) and removed servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) labels Dec 14, 2022
@jander-msft
Copy link
Member

/backport to release/7.x

@github-actions
Copy link
Contributor

Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/3751234025

github-actions bot pushed a commit that referenced this pull request Dec 21, 2022
@kkeirstead
Add Tags for API Requests (#2919)
337131a
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Merged
@jander-msft jander-msft removed the servicing-minor Servicing fixes that is targeted for a minor release (0.x.0 version) label Jan 31, 2023
This was referenced Jan 25, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jander-msft jander-msft jander-msft approved these changes

@schmittjoseph schmittjoseph schmittjoseph approved these changes

@wiktork wiktork wiktork left review comments

Assignees
No one assigned
Labels
update-release-notes Pull requests that should be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag For API Requests
4 participants
@kkeirstead @jander-msft @schmittjoseph @wiktork