Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken links and typos #2672

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

kkeirstead
Copy link
Member

Summary
Release Notes Entry

@kkeirstead kkeirstead requested a review from a team as a code owner October 12, 2022 15:25
@jander-msft jander-msft added the servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) label Oct 12, 2022
@kkeirstead kkeirstead merged commit e0f12a2 into dotnet:main Oct 12, 2022
@jander-msft
Copy link
Member

/backport to release/7.x

@github-actions
Copy link
Contributor

Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/3252611494

@github-actions
Copy link
Contributor

@jander-msft backporting to release/7.x failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fixed ScenarioState name
Applying: Update collectionrules-get.md
Using index info to reconstruct a base tree...
A	documentation/api/collectionrules-get.md
Falling back to patching base and 3-way merge...
Auto-merging documentation/api/collectionrules-individual.md
Applying: Update collectionrules-list.md
Using index info to reconstruct a base tree...
A	documentation/api/collectionrules-list.md
Falling back to patching base and 3-way merge...
Auto-merging documentation/api/collectionrules-all.md
CONFLICT (content): Merge conflict in documentation/api/collectionrules-all.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Update collectionrules-list.md
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@jander-msft jander-msft removed the servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) label Nov 30, 2022
@wiktork
Copy link
Member

wiktork commented Dec 13, 2022

/backport to release/7.x

@github-actions
Copy link
Contributor

Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/3689376781

@github-actions
Copy link
Contributor

@wiktork backporting to release/7.x failed, the patch most likely resulted in conflicts.

Please backport manually using one of the below commands, followed by git am --continue once the merge conflict has been resolved.

PowerShell

(Invoke-WebRequest "https://github.com/dotnet/dotnet-monitor/commit/e0f12a26c962efb67a9a9b28787dd890bba78a05.patch").Content | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

Bash

curl -sSL "https://github.com/dotnet/dotnet-monitor/commit/e0f12a26c962efb67a9a9b28787dd890bba78a05.patch" | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

git am error output:

$ git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch changes.patch

Applying: Fixing broken links and typos (#2672)
Using index info to reconstruct a base tree...
M	src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/Runners/AppRunner.cs
M	src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/TestAppScenarios.cs
M	src/Tests/Microsoft.Diagnostics.Monitoring.UnitTestApp/LoggingExtensions.cs
M	src/Tests/Microsoft.Diagnostics.Monitoring.UnitTestApp/ScenarioHelpers.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Tests/Microsoft.Diagnostics.Monitoring.UnitTestApp/ScenarioHelpers.cs
Auto-merging src/Tests/Microsoft.Diagnostics.Monitoring.UnitTestApp/LoggingExtensions.cs
Auto-merging src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/TestAppScenarios.cs
Auto-merging src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/Runners/AppRunner.cs
CONFLICT (content): Merge conflict in src/Tests/Microsoft.Diagnostics.Monitoring.TestCommon/Runners/AppRunner.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fixing broken links and typos (#2672)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

wiktork pushed a commit to wiktork/dotnet-monitor that referenced this pull request Dec 13, 2022
wiktork added a commit that referenced this pull request Dec 13, 2022
github-actions bot pushed a commit that referenced this pull request Jan 17, 2023
schmittjoseph pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: kkeirstead <[email protected]>

Co-authored-by: Wiktor Kopec <[email protected]>
Co-authored-by: kkeirstead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants