Fix shipping metadata for blob files #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jander-msft
added
servicing-patch
kelltrick
approved these changes
May 8, 2022
They should always be files. Earlier in the file, the PackageFile items should have been globes from the file system. |
|
/backport to release/6.1 |
|
Started backporting to release/6.1: https://github.com/dotnet/dotnet-monitor/actions/runs/2290335690 |
jander-msft
removed
servicing-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata on the PackageFile items was accidentally dropped in #1834, which causes all of the files uploaded to the dotnetbuilds storage account to be marked as non-shipping. This fix includes the metadata from the PackageFile items in the PackageToPublish items to allow shipping vs non-shipping to be tracked correctly.