Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for generatekey #589

Closed
kelltrick opened this issue Jul 20, 2021 · 0 comments · Fixed by #463
Closed

Add tests for generatekey #589

kelltrick opened this issue Jul 20, 2021 · 0 comments · Fixed by #463
Labels
enhancement New feature or request
Milestone

Comments

@kelltrick
Copy link
Contributor

We should add unit tests for the generatekey command. Because it now has output formats and runs in multiple versions of dotnet, we should test the full dotnet version x output format matrix.

@kelltrick kelltrick added the enhancement New feature or request label Jul 20, 2021
@kelltrick kelltrick added this to the Future milestone Jul 27, 2021
kelltrick added a commit that referenced this issue Aug 13, 2021
* Replace MonitorApiKey key/keyhash auth type with signed JWT implementation
* Add MonitorGenerateKeyRunner to test the generatekey command
Closes #463 
Closes #589
jander-msft added a commit that referenced this issue Aug 18, 2021
* Update dependencies from https://github.com/dotnet/diagnostics build 20210810.1 (#707)

[main] Update dependencies from dotnet/diagnostics

* Update dependencies from https://github.com/dotnet/runtime build 20210811.2 (#708)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/aspnetcore build 20210810.16 (#709)

[main] Update dependencies from dotnet/aspnetcore

* Update dependencies from https://github.com/dotnet/diagnostics build 20210811.1 (#711)

[main] Update dependencies from dotnet/diagnostics

* Update dependencies from https://github.com/dotnet/runtime build 20210811.5 (#713)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/aspnetcore build 20210811.15 (#714)

[main] Update dependencies from dotnet/aspnetcore

* Update dependencies from https://github.com/dotnet/arcade build 20210810.8 (#712)

[main] Update dependencies from dotnet/arcade

* Switch to Bearer auth (#463)

* Replace MonitorApiKey key/keyhash auth type with signed JWT implementation
* Add MonitorGenerateKeyRunner to test the generatekey command
Closes #463 
Closes #589

* Update dependencies from https://github.com/dotnet/runtime build 20210813.5 (#717)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/aspnetcore build 20210812.9 (#718)

[main] Update dependencies from dotnet/aspnetcore

* Update dependencies from https://github.com/dotnet/diagnostics build 20210812.1 (#716)

[main] Update dependencies from dotnet/diagnostics

* Add detailed message to output in TestSchemaBaseline (#715)

* Add detailed message to output in TestSchemaBaseline. This shows context when the baseline differs from the generated schema.

* Update dependencies from https://github.com/dotnet/arcade build 20210812.1 (#721)

[main] Update dependencies from dotnet/arcade

* Update dependencies from https://github.com/dotnet/runtime build 20210814.1 (#722)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/runtime build 20210814.4 (#724)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/runtime build 20210815.6 (#725)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/aspnetcore build 20210813.12 (#723)

[main] Update dependencies from dotnet/aspnetcore

* Update dependencies from https://github.com/dotnet/diagnostics build 20210813.1 (#727)

[main] Update dependencies from dotnet/diagnostics

* Update dependencies from https://github.com/dotnet/arcade build 20210813.4 (#728)

[main] Update dependencies from dotnet/arcade

* Update dependencies from https://github.com/dotnet/runtime build 20210817.1 (#729)

[main] Update dependencies from dotnet/runtime

* Update dependencies from https://github.com/dotnet/aspnetcore build 20210817.1 (#730)

[main] Update dependencies from dotnet/aspnetcore

* Small changes to the WithCancellation extension method. (#719)

* Move *EndpointInfo implementations to dotnet-monitor. (#726)

Move *EndpointInfo implementations to dotnet-monitor.
Add dotnet-monitor unit test assembly and move *EndpointInfo tests to it.
Consolidate calculating entry point assembly path into single utility method.

Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Patrick Fenelon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant