Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move .NET 8 preview images to Debian 12 Bookworm #4330

Merged
merged 10 commits into from
Jan 20, 2023
Merged

Move .NET 8 preview images to Debian 12 Bookworm #4330

merged 10 commits into from
Jan 20, 2023

Conversation

lbussell
Copy link
Contributor

Fixes #4322

mthalman
mthalman approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad to see the only updates needed were libicu and libssl versions.

MichaelSimons
MichaelSimons reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be some aspnet/8.0 Dockerfiles that were copied incorrectly. The paths contain both bookworm and bullseye.

See https://github.com/dotnet/dotnet-docker/blob/27e052fe1e49a2aca3f0bbfd48e39f2630dc68f3/src/aspnet/8.0/bookworm-slim/bullseye-slim/amd64/Dockerfile

@mthalman
Copy link
Member

@lbussell - This needs to be synced with nightly. Just need to regenerate the Dockerfiles.

@lbussell
Copy link
Contributor Author

/azp run

@mthalman
Copy link
Member

Looks like pipeline triggers are having issues.

image

@lbussell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@mthalman mthalman merged commit 323fac8 into dotnet:nightly Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
area-dockerfiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbussell @mthalman @MichaelSimons