Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables to baser images #426

Closed
richlander opened this issue Mar 15, 2018 · 4 comments
Closed

Add environment variables to baser images #426

richlander opened this issue Mar 15, 2018 · 4 comments

Comments

@richlander
Copy link
Member

There are a set of environment variables that are useful for certain scenarios. They are either not set or set in the wrong place. I have taken a dependency on these environment variables being set in dotnet images in #420.

The variables:

  • ASPNETCORE_URLS=http://+:80
  • DOTNET_USE_POLLING_FILE_WATCHER=1

The ASPNETCORE_URLS variable should be set in the runtime-deps images. This enables self-contained apps and every other ASP.NET Core scenario.

The DOTNET_USE_POLLING_FILE_WATCHER variable should be set in the SDK image. This is where dotnet watch lives and it doesn't without this variable being set.

These changes should be made for .NET Core 2.1 Preview 2.

@MichaelSimons
Copy link
Member

Thought on setting ASPNETCORE_URLS=http://+:80 in the SDK image as well?

@natemcmaster
Copy link
Contributor

+1 for adding to SDK too. Although not necessarily recommended, people definitely do "dotnet run" in the SDK image to launch their aspnet apps.

@richlander
Copy link
Member Author

Needed for dotnet watch run ;)

Anyway, added it.

@richlander
Copy link
Member Author

This is resolved with #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants