Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Fedora35 Helix image #509

Closed
wants to merge 6 commits into from
Closed

add Fedora35 Helix image #509

wants to merge 6 commits into from

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Sep 15, 2021

contributes to dotnet/core#6446
contributes to #502

in addition it removes old unsupported Fedora32
contributes to dotnet/core#6431

now, locked the old container on release/6.0 branch of dotnet./msquic so it is suitable for 6.0 testing (msquic 1.7)
new container pulls in main and new features and produces msquic 1.8 to test with main of runtime.

contributes to dotnet/runtime#55639

the docker image is mostly clone of existing 34.
since new Fedora uses Python3 be default I removed some old craft & custom pip.

Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helix changes look fine to me, the DNS issues with Fedora sites are mysterious.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do we plan to put msquic on some other distros as well?

@mthalman
Copy link
Member

Adding @omajid to help in diagnosing the build error.

@aik-jahoda aik-jahoda mentioned this pull request Sep 16, 2021
5 tasks
@wfurt
Copy link
Member Author

wfurt commented Sep 17, 2021

This looks like a problem either with the infrastructure or with the base fedora image itself.

Step 2/8 : RUN cat /etc/resolv.conf
 ---> Running in 98ec3aed678b
# This file is managed by man:systemd-resolved(8). Do not edit.
#
# This is a dynamic resolv.conf file for connecting local clients directly to
# all known uplink DNS servers. This file lists all configured search domains.
#
# Third party programs must not access this file directly, but only through the
# symlink at /etc/resolv.conf. To manage man:resolv.conf(5) in a different way,
# replace this symlink by a static file or a different symlink.
#
# See man:systemd-resolved.service(8) for details about the supported modes of
# operation for /etc/resolv.conf.

nameserver 168.63.129.16
search owz4dc5o1g0evnwcscpbtikkfe.xx.internal.cloudapp.net
Removing intermediate container 98ec3aed678b
 ---> c1d5e2e5d871
Step 3/8 : RUN curl -v http://google.com/
 ---> Running in a96309a7f6ec
* getaddrinfo() thread failed to start
* Could not resolve host: google.com
* Closing connection 0
curl: (6) getaddrinfo() thread failed to start

Retry 1/5, retrying in 1 seconds...
The command '/bin/sh -c curl -v http://google.com/' returned a non-zero code: 6
Sending build context to Docker daemon  4.608kB

I'm not sure where the 168.63.129.16 comes from but the container is unable to resolve names.
cc: @tmds as well for ideas.

@omajid
Copy link
Member

omajid commented Sep 17, 2021

The error message seems to suggest that this is actions/runner-images#3812

@wfurt
Copy link
Member Author

wfurt commented Sep 17, 2021

Looks like the 168.63. 129.16 is Azure name server so it is probably ok.

@wfurt
Copy link
Member Author

wfurt commented Sep 17, 2021

The will be problematic even for helix, right @omajid e.g. it is not just problem building the image...

@mthalman
Copy link
Member

@chrispat - Any idea when the moby fix mentioned in actions/runner-images#3812 will make its way into Azure DevOps Linux hosted agents?

@chrispat
Copy link

Azure DevOps and GitHub Actions use the same Linux images. So it should make it to both at the same time.

@wfurt
Copy link
Member Author

wfurt commented Sep 21, 2021

I'm not sure what is next step here. Wait? If so, is there some trigger to know it is ready? For the QUIC changes I can go back to Fedora34 but I guess reason for the updated test matrix is to spot issues early.

@omajid
Copy link
Member

omajid commented Sep 22, 2021

@wfurt we can work around failures when running the container by disabling security policy as suggested at actions/runner-images#3812 (comment) but I don't know of a solution for docker build.

I can't see anything we (.NET folks) can do here short of waiting for updated moby.

@wfurt
Copy link
Member Author

wfurt commented Sep 22, 2021

Thanks for update @omajid. I'll probably split the PR and proceed with the QUIC changes independently. It also feels safe to nuke the 32, right? I originally nuke it from the manifest but I'm wondering if we should delete the files as well. Any preference @mthalman ?

@mthalman
Copy link
Member

It also feels safe to nuke the 32, right? I originally nuke it from the manifest but I'm wondering if we should delete the files as well. Any preference @mthalman?

Deleting the files seems appropriate.

@aik-jahoda
Copy link
Contributor

@wfurt, is there a way I can help there? For example move helix image to another PR?

@wfurt
Copy link
Member Author

wfurt commented Sep 24, 2021

I'm not sure what you suggesting @aik-jahoda. From what I understand the new Fedora (and some other distributions) will not function in current infrastructure.

@omajid
Copy link
Member

omajid commented Sep 27, 2021

Same issue also affects RHEL 9: #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants