Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for new function pointer support #8875

Merged
merged 10 commits into from
Sep 1, 2023

Conversation

steveharter
Copy link
Member

@steveharter steveharter commented Feb 27, 2023

Adds new doc for the new APIs added for .NET 8.0 Preview 2.

@dotnet dotnet deleted a comment from learn-build-service-prod bot Feb 27, 2023
@dotnet dotnet deleted a comment from learn-build-service-prod bot Feb 27, 2023
@steveharter
Copy link
Member Author

@docs this is for .NET 8.0 (Preview 2). The Preview URL doesn't yet support .NET 8.0 -- any way to verify the changes?

@dotnet dotnet deleted a comment from learn-build-service-prod bot Aug 17, 2023
@dotnet dotnet deleted a comment from learn-build-service-prod bot Aug 17, 2023
@dotnet dotnet deleted a comment from learn-build-service-prod bot Aug 17, 2023
@dotnet dotnet deleted a comment from learn-build-service-prod bot Aug 17, 2023
@dotnet dotnet deleted a comment from learn-build-service-prod bot Aug 17, 2023
@dotnet dotnet deleted a comment from learn-build-service-prod bot Aug 17, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit 5a5bd6a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/FieldInfo.xml ✅Succeeded View
xml/System.Reflection/ParameterInfo.xml ✅Succeeded View
xml/System.Reflection/PropertyInfo.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop
Copy link
Member

Is this ready to review?

@steveharter
Copy link
Member Author

Is this ready to review?

Yes, thanks.

@steveharter steveharter marked this pull request as ready for review August 17, 2023 19:39
@steveharter steveharter requested a review from a team as a code owner August 17, 2023 19:39
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some NIT, overall LGTM

xml/System.Reflection/FieldInfo.xml Outdated Show resolved Hide resolved
xml/System.Reflection/ParameterInfo.xml Outdated Show resolved Hide resolved
xml/System.Reflection/PropertyInfo.xml Outdated Show resolved Hide resolved
xml/System/Type.xml Show resolved Hide resolved
xml/System/Type.xml Show resolved Hide resolved
xml/System/Type.xml Show resolved Hide resolved
@learn-build-service-prod
Copy link

Learn Build status updates of commit 0d6000b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/FieldInfo.xml ✅Succeeded View
xml/System.Reflection/ParameterInfo.xml ✅Succeeded View
xml/System.Reflection/PropertyInfo.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@steveharter steveharter merged commit 16cdc53 into dotnet:main Sep 1, 2023
2 checks passed
@steveharter steveharter deleted the FunctionPointers branch September 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants