-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remark about Unix for SetEnvironmentVariable #8306
Conversation
Docs Build status updates of commit 8bab2de: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@janvorli can you confirm this update is correct? |
Co-authored-by: Jan Kotas <[email protected]>
Learn Build status updates of commit d99ad39: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you addressed the PR feedback. @janvorli any other notes?
@parched I am sorry - I have pushed a chance into your PR that replaced a few more Linux and macOS references with non-Windows systems for consistency and it want you to sign the CLA now. Would you mind signing the CLA? |
Learn Build status updates of commit 03d7ccd: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Close/reopen for CLA. |
Learn Build status updates of commit 03d7ccd: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@jkotas no problem, I have signed the CLA. |
In regard to dotnet/runtime#9529, mention that
SetEnvironmentVariable
doesn't effect native libraries.