Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark about Unix for SetEnvironmentVariable #8306

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

parched
Copy link
Contributor

@parched parched commented Aug 15, 2022

In regard to dotnet/runtime#9529, mention that SetEnvironmentVariable doesn't effect native libraries.

@parched parched requested a review from a team as a code owner August 15, 2022 01:58
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2022
@opbld30
Copy link

opbld30 commented Aug 15, 2022

Docs Build status updates of commit 8bab2de:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@dakersnar
Copy link
Contributor

@janvorli can you confirm this update is correct?

xml/System/Environment.xml Outdated Show resolved Hide resolved
xml/System/Environment.xml Outdated Show resolved Hide resolved
xml/System/Environment.xml Outdated Show resolved Hide resolved
@opbld34
Copy link

opbld34 commented Oct 10, 2022

Learn Build status updates of commit d99ad39:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@dakersnar dakersnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you addressed the PR feedback. @janvorli any other notes?

@dnfadmin
Copy link

dnfadmin commented Oct 10, 2022

CLA assistant check
All CLA requirements met.

@jkotas
Copy link
Member

jkotas commented Oct 10, 2022

@parched I am sorry - I have pushed a chance into your PR that replaced a few more Linux and macOS references with non-Windows systems for consistency and it want you to sign the CLA now. Would you mind signing the CLA?

@opbld31
Copy link

opbld31 commented Oct 10, 2022

Learn Build status updates of commit 03d7ccd:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor

Close/reopen for CLA.

@gewarren gewarren closed this Oct 12, 2022
@gewarren gewarren reopened this Oct 12, 2022
@opbld30
Copy link

opbld30 commented Oct 13, 2022

Learn Build status updates of commit 03d7ccd:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@parched
Copy link
Contributor Author

parched commented Oct 13, 2022

@jkotas no problem, I have signed the CLA.

@gewarren gewarren merged commit 459da22 into dotnet:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants