-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing doc to the Metrics APIs and TimeOnly type. #8229
Conversation
Tagging subscribers to this area: @tommcdon Issue Detailsdotnet/runtime#72409
|
@carlossanlop could you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tarekgh . I left some suggestions.
Co-authored-by: Carlos Sanchez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more additional suggestions to use cref. Aside from that, LGTM.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
Docs Build status updates of commit 1b49c3d: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 3d7372e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
dotnet/runtime#72409
dotnet/runtime#72404