Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing doc to the Metrics APIs and TimeOnly type. #8229

Merged
merged 6 commits into from
Jul 19, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 18, 2022

@tarekgh tarekgh requested a review from a team as a code owner July 18, 2022 23:15
@ghost ghost assigned tarekgh Jul 18, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet/runtime#72409
dotnet/runtime#72404

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Diagnostics

Milestone: -

@tarekgh
Copy link
Member Author

tarekgh commented Jul 18, 2022

@carlossanlop could you please have a look?

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tarekgh . I left some suggestions.

xml/System.Diagnostics.Metrics/Meter.xml Outdated Show resolved Hide resolved
xml/System/TimeOnly.xml Outdated Show resolved Hide resolved
xml/System/TimeOnly.xml Outdated Show resolved Hide resolved
xml/System/TimeOnly.xml Outdated Show resolved Hide resolved
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more additional suggestions to use cref. Aside from that, LGTM.

xml/System/TimeOnly.xml Outdated Show resolved Hide resolved
xml/System/TimeOnly.xml Outdated Show resolved Hide resolved
@opbld30

This comment was marked as outdated.

tarekgh and others added 2 commits July 18, 2022 16:47
Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
@carlossanlop carlossanlop enabled auto-merge (squash) July 18, 2022 23:54
@opbld32
Copy link

opbld32 commented Jul 19, 2022

Docs Build status updates of commit 1b49c3d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml ✅Succeeded View
xml/System/TimeOnly.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Jul 19, 2022

Docs Build status updates of commit 3d7372e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics.Metrics/Meter.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/ObservableUpDownCounter`1.xml ✅Succeeded View
xml/System/TimeOnly.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants