-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify/fix some threading API docs #7137
Conversation
- Clarify terms used in `LazyThreadSafetyMode` field names. Relevant to dotnet/docs#12214. - Clarify documentation of the `Volatile` class. Relevant to dotnet/docs#24318. - Update docs for `Thread.VolatileRead` and `Thread.VolatileWrite`. Fixes dotnet#2518. - Clarify something about `ManualResetEventSlim`'s perf benefit over `ManualResetEvent`. Fixes dotnet#3323.
Docs Build status updates of commit 16dc07c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@@ -982,7 +985,7 @@ | |||
</Parameters> | |||
<Docs> | |||
<param name="location">The field where the value is written.</param> | |||
<param name="value">The value to write. The value is written immediately so that it is visible to all processors in the computer.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the extra clarification not required, or has the behavior now changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior hasn't changed, just removing the statement since it's incorrect
Thank you! Co-authored-by: Genevieve Warren <[email protected]>
Docs Build status updates of commit 523633a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
LazyThreadSafetyMode
field names. Relevant to Why ExecutionAndPublication and PublicationOnly have such names? docs#12214.Volatile
class. Relevant to Improve documentation ofvolatile
keyword docs#24318.Thread.VolatileRead
andThread.VolatileWrite
. Fixes Thread.VolatileRead/Write remarks and volatile keyword #2518.ManualResetEventSlim
's perf benefit overManualResetEvent
. Fixes Define "very short" in Remark for ManualResetEventSlim #3323.