Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify/fix some threading API docs #7137

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

kouvel
Copy link
Member

@kouvel kouvel commented Sep 10, 2021

- Clarify terms used in `LazyThreadSafetyMode` field names. Relevant to dotnet/docs#12214.
- Clarify documentation of the `Volatile` class. Relevant to dotnet/docs#24318.
- Update docs for `Thread.VolatileRead` and `Thread.VolatileWrite`. Fixes dotnet#2518.
- Clarify something about `ManualResetEventSlim`'s perf benefit over `ManualResetEvent`. Fixes dotnet#3323.
@opbld31
Copy link

opbld31 commented Sep 10, 2021

Docs Build status updates of commit 16dc07c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/LazyThreadSafetyMode.xml ✅Succeeded View
xml/System.Threading/ManualResetEventSlim.xml ✅Succeeded View
xml/System.Threading/Thread.xml ✅Succeeded View
xml/System.Threading/Volatile.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -982,7 +985,7 @@
</Parameters>
<Docs>
<param name="location">The field where the value is written.</param>
<param name="value">The value to write. The value is written immediately so that it is visible to all processors in the computer.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the extra clarification not required, or has the behavior now changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior hasn't changed, just removing the statement since it's incorrect

xml/System.Threading/LazyThreadSafetyMode.xml Outdated Show resolved Hide resolved
xml/System.Threading/LazyThreadSafetyMode.xml Outdated Show resolved Hide resolved
xml/System.Threading/ManualResetEventSlim.xml Outdated Show resolved Hide resolved
xml/System.Threading/Volatile.xml Outdated Show resolved Hide resolved
xml/System.Threading/Volatile.xml Show resolved Hide resolved
xml/System.Threading/Volatile.xml Show resolved Hide resolved
xml/System.Threading/Volatile.xml Outdated Show resolved Hide resolved
Thank you!

Co-authored-by: Genevieve Warren <[email protected]>
@opbld32
Copy link

opbld32 commented Sep 11, 2021

Docs Build status updates of commit 523633a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/LazyThreadSafetyMode.xml ✅Succeeded View
xml/System.Threading/ManualResetEventSlim.xml ✅Succeeded View
xml/System.Threading/Thread.xml ✅Succeeded View
xml/System.Threading/Volatile.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants