Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HttpRequestException.StatusCode property #4042

Closed
wants to merge 9 commits into from

Conversation

alnikola
Copy link
Contributor

HttpRequestException.StatusCode property gets the HTTP status code associated with the exception if any.
It was introduced in dotnet/runtime#32455

HttpRequestException.StatusCode property gets the HTTP status code associated with the exception if any.
It was introduced in dotnet/runtime##32455
@alnikola alnikola requested a review from a team March 26, 2020 14:59
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 26, 2020
@davidsh davidsh requested a review from gewarren March 26, 2020 15:07
<MemberType>Property</MemberType>
<AssemblyInfo>
<AssemblyName>System.Net.Http</AssemblyName>
<AssemblyVersion>5.0.0.0</AssemblyVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren is there a way to specify that this property is new in .NET Core 5.0?
The fact it is also part of System.Net.Http is IMO not interesting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I missed this. I left a suggestion about adding a note in the Remarks. Does that work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Applies to section would also indicate the versions the property exists.

@gewarren
Copy link
Contributor

Close/reopen to try build again.

@gewarren gewarren closed this Apr 14, 2020
@gewarren gewarren reopened this Apr 14, 2020
@gewarren
Copy link
Contributor

I don't understand why the build is failing. I've asked for help on the Docs support channel.

@gewarren
Copy link
Contributor

gewarren commented Apr 16, 2020

@alnikola The answer from the support channel is:

"We should never manually add members to a ECMAXML file. The skeleton of a ECMAXML file should always be auto-generated by CI. If these members are meant to be there, could you please update the binaries and re-run the CI?"

Do you need @BillWagner to rerun the CI?

@alnikola
Copy link
Contributor Author

@gewarren @BillWagner What is the standard process for skeleton regeneration? Is it normally done before each release?
I'm afraid if we rerun CI now, it will bring in not only my changes, but many others.

@alnikola
Copy link
Contributor Author

@carlossanlop I'm waiting for a reply from @gewarren or @BillWagner to understand what is the skeleton regeneration process and if it's safe to do it now. It seems the only way to build an updated ECMAXML file with the new members I added.

@gewarren
Copy link
Contributor

@mairaw , Could you weigh in here?

@mairaw
Copy link
Contributor

mairaw commented Apr 27, 2020

Typically we wait until the members show up in the build automatically and then port any existing comments from the source.
I believe @BillWagner is working with @safern to get the Preview 3 assemblies in (we still have Preview 1 on the site). If this would show up later, then we need to wait.

So yeah the entire CI would bring all the changes since Preview 1 in. Then your PR could concentrate only on the new property content.

@carlossanlop
Copy link
Member

Thanks @mairaw for replying.
@alnikola This PR is essentially blocked until we update MS Docs with the latest ref assemblies. Feel free to close it and add your changes after the API shows up in MS Docs.

@alnikola
Copy link
Contributor Author

Closing PR until MS Docs is updated as suggested above.

@alnikola alnikola closed this Apr 28, 2020
@gewarren gewarren deleted the alnikola/http-request-exception-status-code branch October 8, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants