-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New HttpRequestException.StatusCode property #4042
Conversation
HttpRequestException.StatusCode property gets the HTTP status code associated with the exception if any. It was introduced in dotnet/runtime##32455
<MemberType>Property</MemberType> | ||
<AssemblyInfo> | ||
<AssemblyName>System.Net.Http</AssemblyName> | ||
<AssemblyVersion>5.0.0.0</AssemblyVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gewarren is there a way to specify that this property is new in .NET Core 5.0?
The fact it is also part of System.Net.Http is IMO not interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I missed this. I left a suggestion about adding a note in the Remarks. Does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Applies to section would also indicate the versions the property exists.
Co-Authored-By: Genevieve Warren <[email protected]>
Co-Authored-By: Genevieve Warren <[email protected]>
Co-Authored-By: Genevieve Warren <[email protected]>
Close/reopen to try build again. |
I don't understand why the build is failing. I've asked for help on the Docs support channel. |
@alnikola The answer from the support channel is: "We should never manually add members to a ECMAXML file. The skeleton of a ECMAXML file should always be auto-generated by CI. If these members are meant to be there, could you please update the binaries and re-run the CI?" Do you need @BillWagner to rerun the CI? |
@gewarren @BillWagner What is the standard process for skeleton regeneration? Is it normally done before each release? |
@carlossanlop I'm waiting for a reply from @gewarren or @BillWagner to understand what is the skeleton regeneration process and if it's safe to do it now. It seems the only way to build an updated ECMAXML file with the new members I added. |
@mairaw , Could you weigh in here? |
Typically we wait until the members show up in the build automatically and then port any existing comments from the source. So yeah the entire CI would bring all the changes since Preview 1 in. Then your PR could concentrate only on the new property content. |
Closing PR until MS Docs is updated as suggested above. |
HttpRequestException.StatusCode property gets the HTTP status code associated with the exception if any.
It was introduced in dotnet/runtime#32455