-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# Xml doc #798
C# Xml doc #798
Conversation
Hi @tsolarin, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
@@ -58,5 +58,5 @@ to know what's next --> | |||
* [Summary](expression-trees-summary.md) | |||
* [🔧 Native interoperability](interop.md) | |||
* [🔧 Reflection & code generation](reflection.md) | |||
* [🔧 Documenting your code](codedoc.md) | |||
* [Documenting your code](codedoc.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrench should also be removed from docs/toc.md
.
@tsolarin This is a good start. Overall, you know the topic well, and the information is all here. I'd like to see this become more of a tutorial or guide, and less of a reference document. The C# spec contains information on the tags and their syntax. This article can really help readers by giving them examples and recommendations on using the /// comments in their own libraries. There are questions that the spec doesn't answer that should be in this topic:
Again, thank you for contributing. We really appreciate seeing people get involved in the project, and helping make a better experience for the .NET Community. |
@BillWagner @svick thanks for the reviews, I'll get to addressing your comments and will mention you guys again when it's ready for re-review |
@tsolarin I saw that you pushed an update, but I didn't know if you were ready for a review yet. Should I give this a look over, or should I wait for further updates? |
@BillWagner I have one more update coming and then it should be ready for another review |
Ready for another look over /cc @BillWagner @svick |
Notifying again /cc @BillWagner @svick |
} | ||
</code> | ||
</example> | ||
<exception cref="System.OverflowException">Thrown when one parameter is max and the other is greater than 0.</exception> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split into 2 lines.
@tsolarin This looks really good. I left a few final (minor) comments. Some are also suggestions. You should decide if you like that style or not. Can you fix the merge conflicts? I think those are in the TOC changes. Let me know if you've used |
@BillWagner thanks. I can do a rebase alright. Quick question though, on splitting of the contents of the |
@tsolarin A normal line break. Code lines don't auto wrap, so those force the user to scroll to the right. |
Merge conflicts all fixed up, and comments addressed. Ready for another go |
I gave it a final review, and it's ready to merge, as soon as the CI build finishes. Thank you for all your work on this. It's a great addition, and I hope you enjoyed the experience. 🎆 |
👍, thanks @tsolarin! Great article. |
@BillWagner @cartermp thanks a lot, I really enjoyed the experience and learnt a whole lot in the process. Looking forward to contributing some more. |
This PR adds content for C# Code documentation.
Changes include
project.json
Fixes #67
/cc @BillWagner