-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document built-in System.Net activities #43872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonfirsov
commented
Dec 5, 2024
docs/core/diagnostics/distributed-tracing-builtin-activities.md
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Dec 5, 2024
tarekgh
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe @MihaZupan can help looking too to validate the details.
gewarren
approved these changes
Dec 5, 2024
docs/core/diagnostics/distributed-tracing-builtin-activities.md
Outdated
Show resolved
Hide resolved
docs/core/diagnostics/distributed-tracing-builtin-activities.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
MihaZupan
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
docs/core/diagnostics/distributed-tracing-builtin-activities.md
Outdated
Show resolved
Hide resolved
docs/core/diagnostics/distributed-tracing-builtin-activities.md
Outdated
Show resolved
Hide resolved
docs/core/diagnostics/distributed-tracing-builtin-activities.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 9 introduced additions to
System.Net
distributed tracing which define a contract following OTel recommendations:This PR documents the activities together with their attributes in a manner similar to the metrics docs added by #37213. The matching semconv PR is open-telemetry/semantic-conventions#1192. Conceptual docs are being introduced in #42830.
Moreover, the PR also adjusts certain parts of the metrics doc in order to make it more accurate, synchronize it with the activities doc and incorporate the changes from #42810.
Internal previews