-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update streams-programming-apis.md implicit subscription section to b… #41988
Conversation
…e more clear Adds information regarding implementing IAsyncObserver<T> and IStreamSubscriptionObserver for Implicit Streams instead of explicitly subscribing (which does not apply in the case of an implicit subscription)
@dotnet-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but let's include @mikekistler to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
I'll defer to @ReubenBond on the technical details, but I suggested one minor wording change.
Suggestion / Word Correction Co-authored-by: Mike Kistler <[email protected]>
Summary
The section for Microsoft Orleans Streams Programming is missing information regarding how to implement Implicit Streams using the
IAsyncOberserver
andIStreamSubscriptionObserver
interfaces. The documentation currently states that an explicit subscription is required, but implicit subscriptions can be supported by implementing two interfaces.Adds information regarding implementing IAsyncObserver and IStreamSubscriptionObserver for Implicit Streams instead of explicitly subscribing (which
does not applyis not required in the case of an implicit subscription)Internal previews