Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOTNET_EnableDiagnostics setting documentation #38931

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

tommcdon
Copy link
Member

@tommcdon tommcdon commented Jan 1, 2024

Summary

Clarifies documentation as mentioned in dotnet/runtime#96227 (comment).

Fixes dotnet/runtime#96227


Internal previews

📄 File 🔗 Preview link
docs/core/tools/dotnet-environment-variables.md .NET environment variables

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few suggestions for style changes and typo fixes.

docs/core/tools/dotnet-environment-variables.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-environment-variables.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-environment-variables.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-environment-variables.md Outdated Show resolved Hide resolved
@tommcdon tommcdon merged commit 4096445 into dotnet:main Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOTNET_EnableDiagnostics=0 disables profiling in .NET 8
3 participants