-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reflection fallback breaking change doc. #31235
Merged
eiriktsarpalis
merged 8 commits into
dotnet:main
from
eiriktsarpalis:reflection-fallback-update
Sep 16, 2022
Merged
Improve reflection fallback breaking change doc. #31235
eiriktsarpalis
merged 8 commits into
dotnet:main
from
eiriktsarpalis:reflection-fallback-update
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
Sep 16, 2022
gewarren
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eiriktsarpalis!
docs/core/compatibility/serialization/7.0/reflection-fallback.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/serialization/7.0/reflection-fallback.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/serialization/7.0/reflection-fallback.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/serialization/7.0/reflection-fallback.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/serialization/7.0/reflection-fallback.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/serialization/7.0/reflection-fallback.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the recommended actions section of the JSON source gen reflection fallback breaking change doc, and documents the newly added appcontext switch in dotnet/runtime#75615