Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invariant mode breaking change #25305

Merged
merged 8 commits into from
Jul 23, 2021
Merged

Invariant mode breaking change #25305

merged 8 commits into from
Jul 23, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 22, 2021 •
edited
Loading

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 22, 2021
@gewarren gewarren requested review from tarekgh and a team July 23, 2021 01:04
tdykstra
tdykstra approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one typo

docs/core/compatibility/globalization/6.0/culture-creation-invariant-mode.md Outdated Show resolved Hide resolved
tarekgh
tarekgh approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. added a couple of minor comments.

@gewarren gewarren merged commit cd25628 into dotnet:main Jul 23, 2021
@gewarren gewarren deleted the invariant-mode branch July 23, 2021 19:55
@gewarren
Copy link
Contributor Author

Thanks for reviewing Tom and Tarek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.

Restrict Cultures Creation and full support casing in Globalization Invariant Mode
4 participants
@gewarren @tdykstra @tarekgh @dotnet-bot