Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use of non-public constructors #22461

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Add use of non-public constructors #22461

merged 3 commits into from
Jan 25, 2021

Conversation

gewarren
Copy link
Contributor

Fixes #22069.

@dotnet-bot dotnet-bot added this to the January 2021 milestone Jan 23, 2021
tdykstra
tdykstra approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I thought we had to change <T> xref links from backtick-1 to %601 but these are rendering correctly.

@gewarren
Copy link
Contributor Author

LGTM

I thought we had to change xref links from backtick-1 to %601 but these are rendering correctly.

I knew it didn't look quite right!

@gewarren gewarren merged commit c503251 into master Jan 25, 2021
@gewarren gewarren deleted the gewarren-patch-1 branch January 25, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

Misleading wording for serializer behavior description.
4 participants
@gewarren @tdykstra @BillWagner @dotnet-bot