New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F# plaintext printing documentation #19632

Merged

cartermp merged 78 commits into dotnet:master from dsyme:fsharp-plaintext

Aug 4, 2020

Contributor

dsyme commented Jul 22, 2020

Summary

Adds information to the F# language guide on structured plaintext printing in F# and the mechanisms available to customize it

(@cartermp - separately, we should add a page on printf in general)


          plaintext printing documentation

d28c5d3

dsyme requested a review from cartermp as a code owner

July 22, 2020 13:00

dotnet-bot added this to the July 2020 milestone

dotnet-bot added the 📚 Area - F# Guide label

dsyme mentioned this pull request

F# values display badly in default formatting, esp plaintext dotnet/interactive#642

Open

Youssef1313 reviewed

View reviewed changes

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

Youssef1313 reviewed

View reviewed changes

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

dsyme and others added 2 commits

July 22, 2020 16:37


          Update docs/fsharp/language-reference/plaintext-formatting.md

cb774e1

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

7c58838

Co-authored-by: Youssef Victor <[email protected]>

cartermp suggested changes

View reviewed changes

Contributor

cartermp left a comment

first quick review pass

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

dsyme and others added 6 commits

July 22, 2020 17:58


          Update docs/fsharp/language-reference/plaintext-formatting.md

22d5d7a

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

0d4c566

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

a62c18e

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

28b3dbe

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

2a73064

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

d0e394f

Co-authored-by: Phillip Carter <[email protected]>

Youssef1313 suggested changes

View reviewed changes

Member

Youssef1313 left a comment •

edited

Loading

Styling changes. You may need until it's reviewed before committing them.

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

dsyme and others added 13 commits

July 22, 2020 18:42


          Update docs/fsharp/language-reference/plaintext-formatting.md

2ed567c

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

3e315a6

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

a30abea

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

f7b7cf7

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

081e138

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

35b695e

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

dd05c96

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

b144740

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

24c6173

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

1521b93

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

4b5e57d

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

1de04e9

Co-authored-by: Youssef Victor <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

7e21846

Co-authored-by: Youssef Victor <[email protected]>

Contributor

cartermp commented Aug 4, 2020

@dsyme I recommend looking at the remaining suggestions from @gewarren , such as here: https://github.com/dotnet/docs/pull/19632/files#r463183291

I could see these subtitles being either. I would prefer not starting with %A in them if possible.

cartermp reviewed

View reviewed changes

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/plaintext-formatting.md Show resolved Hide resolved

dsyme and others added 17 commits

August 4, 2020 03:51


          Update docs/fsharp/language-reference/plaintext-formatting.md

1e20bb0

Co-authored-by: Genevieve Warren <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

c3f48b1

Co-authored-by: Genevieve Warren <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

0d3a1f1

Co-authored-by: Genevieve Warren <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

0257abb

Co-authored-by: Genevieve Warren <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

d46d1c8

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

8e34ab8

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

1be9163

Co-authored-by: Genevieve Warren <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

41e0ae6

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

7c17936

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

035ab50

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

ff561d0

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

e2e9597

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

6110a82

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

1e3c523

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

512cdc9

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/plaintext-formatting.md

a456db9

Co-authored-by: Phillip Carter <[email protected]>

Contributor Author

dsyme commented Aug 4, 2020

@cartermp Cool thanks, I've been through and accepted them now

cartermp approved these changes

View reviewed changes

Contributor

cartermp left a comment

Approved pending these changes!

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

docs/fsharp/language-reference/fsharp-interactive-options.md Outdated Show resolved Hide resolved

dsyme and others added 2 commits

August 4, 2020 04:21


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

301ef8e

Co-authored-by: Phillip Carter <[email protected]>


          Update docs/fsharp/language-reference/fsharp-interactive-options.md

9fd796d

Co-authored-by: Phillip Carter <[email protected]>

Contributor Author

dsyme commented Aug 4, 2020

Have I got them all now? :-)

cartermp requested a review from gewarren

August 4, 2020 03:25

gewarren approved these changes

View reviewed changes

Contributor

cartermp commented Aug 4, 2020

Yeeeee

cartermp merged commit a61b508 into dotnet:master

BillWagner added dotnet-fsharp/svc and removed 📚 Area - F# Guide labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet-fsharp/svc