Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New article - Migrate from Newtonsoft.Json #16225

Merged
merged 76 commits into from
Jan 11, 2020
Merged

New article - Migrate from Newtonsoft.Json #16225

merged 76 commits into from
Jan 11, 2020

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Dec 12, 2019 •
edited
Loading

@dotnet-bot dotnet-bot added this to the December 2019 milestone Dec 12, 2019
@tdykstra tdykstra closed this Dec 13, 2019
@tdykstra tdykstra reopened this Dec 13, 2019
@tdykstra tdykstra closed this Dec 13, 2019
@tdykstra tdykstra reopened this Dec 13, 2019
@tdykstra tdykstra changed the title WIP: Migrate from Json.NET article Migrate from Json.NET article Dec 13, 2019
@tdykstra tdykstra marked this pull request as ready for review December 13, 2019 18:59
@tdykstra tdykstra changed the title Migrate from Json.NET article New article - Migrate from Json.NET Dec 16, 2019
@ericstj
Copy link
Member

ericstj commented Dec 16, 2019

@tdykstra thank you for the huge doc!

@ahsonkhan @layomia @steveharter please have a look and help fill this out.

@ericstj
Copy link
Member

ericstj commented Dec 16, 2019

Also @pranavkm @rynowak

pranavkm
pranavkm reviewed Dec 16, 2019
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
Thraka
Thraka suggested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I think you should consider, and a few bugs

docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-how-to.md Outdated Show resolved Hide resolved
docs/standard/serialization/toc.yml Outdated Show resolved Hide resolved
@tdykstra tdykstra removed the request for review from HongGit January 10, 2020 20:30
@tdykstra tdykstra merged commit eeecda4 into dotnet:master Jan 11, 2020
@tdykstra tdykstra deleted the jnmigrate branch January 11, 2020 15:18
@ahsonkhan
Copy link
Member

ahsonkhan commented Jan 12, 2020 •
edited
Loading

@tdykstra merged commit eeecda4 into dotnet:master yesterday

Hurray! Great job.

This was referenced Jan 13, 2020
Closed
Closed
Closed
@layomia layomia mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layomia layomia layomia left review comments

@ahsonkhan ahsonkhan ahsonkhan left review comments

@BillWagner BillWagner BillWagner approved these changes

@pranavkm pranavkm pranavkm left review comments

@Thraka Thraka Thraka approved these changes

@terrajobst terrajobst Awaiting requested review from terrajobst

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.

Create doc for System.Text.Json: migration from Json.NET / current limitations
8 participants
@tdykstra @ericstj @ahsonkhan @pranavkm @BillWagner @Thraka @layomia @dotnet-bot