Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish policy for stale PRs #42438

Closed
BillWagner opened this issue Sep 3, 2024 · 0 comments · Fixed by #42638
Closed

Establish policy for stale PRs #42438

BillWagner opened this issue Sep 3, 2024 · 0 comments · Fixed by #42638
Assignees
@BillWagner
Labels
in-pr This issue will be closed (fixed) by an active pull request. okr-freshness OKR: Freshness of content 📌 seQUESTered Identifies that an issue has been imported into Quest. resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] style-guide Indicates issues or PRs that are about following the rules from style guide/contributor guide

Comments

@BillWagner
Copy link
Member

BillWagner commented Sep 3, 2024 •
edited by sequestor bot
Loading

Describe the issue or suggestion

We have a growing number of stale PRs in our docs repositories. I will add new information in the admin folder of this repo, and duplicate it in the contributor guide.

As part of this, I'll cleanup the info in the styleguide folder. The 3rd party dependencies will move to the admin folder, and the other articles will get consolidated in a "more information in the public contributor guide" style.

I propose the following policy for stale PRs:

  • PRs with no activity (discussion or commits) for 30 days will be closed with a note to the author that they can reopen and make any necessary updates.
  • Team members will accept suggestions and merge PRs.
  • Team members aren't expected to do any additional work for other authors in order to meet quality or correctness gates. However, they will help guide authors to achieve the quality gates.

Associated WorkItem - 307294
@BillWagner BillWagner self-assigned this Sep 3, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Sep 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-freshness OKR: Freshness of content label Sep 3, 2024
@BillWagner BillWagner added style-guide Indicates issues or PRs that are about following the rules from style guide/contributor guide 🗺️ reQUEST Triggers an issue to be imported into Quest. and removed ⌚ Not Triaged Not triaged Pri3 okr-freshness OKR: Freshness of content labels Sep 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-freshness OKR: Freshness of content label Sep 3, 2024
@BillWagner BillWagner mentioned this issue Sep 3, 2024
Closed
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Sep 4, 2024
BillWagner added a commit to BillWagner/docs that referenced this issue Sep 17, 2024
@BillWagner
Set policy for stale / abandoned PRs
f66a16c 
Fixes dotnet#42438

The substantive changes are to add a policy statement on closing stale or abandoned PRs to the readme.md.

Other changes are to remove files that were placeholders, and to update links to the appropriate location in the public contributor guide.
@BillWagner BillWagner mentioned this issue Sep 17, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label Sep 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs September 2024 Sprint Sep 25, 2024
@dotnetrepoman dotnetrepoman bot added resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillWagner BillWagner

Labels
in-pr This issue will be closed (fixed) by an active pull request. okr-freshness OKR: Freshness of content 📌 seQUESTered Identifies that an issue has been imported into Quest. resolved-by-customer Indicates issues where the customer no longer needs any help. [org][resolution] style-guide Indicates issues or PRs that are about following the rules from style guide/contributor guide
Projects
No open projects
dotnet/docs September 2024 Sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set policy for stale / abandoned PRs BillWagner/docs
3 participants
@BillWagner @dotnet-bot and others