Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop .NET 7 SDK supports #9911

Merged
merged 1 commit into from
May 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ jobs:

- run: dotnet test -c Release -f net8.0 --no-build --collect:"XPlat Code Coverage"

- run: dotnet test -c Release -f net7.0 --no-build --collect:"XPlat Code Coverage"
if: matrix.os == 'ubuntu-latest'

- run: dotnet test -c Release -f net6.0 --no-build --collect:"XPlat Code Coverage"
if: matrix.os == 'ubuntu-latest'

Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,21 @@ on:
schedule:
- cron: '0 0 * * *'

env:
DOCFX_PREVIEW_BUILD: true

jobs:
publish-github-packages:
if: github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
permissions:
packages: write
steps:
- uses: actions/setup-dotnet@v4
with:
dotnet-version: |
9.x

- uses: actions/checkout@v4
with:
fetch-depth: 0
Expand All @@ -20,6 +28,9 @@ jobs:
version_format: ${major}.${minor}.${patch}-preview.${increment}

- uses: ./.github/actions/build

- name: dotnet test
run: dotnet test -c Release -f net9.0 --no-build

- name: dotnet pack
run: dotnet pack -c Release /p:Version=${{ steps.version.outputs.version }} -o drop/nuget
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
name: nuget
path: drop/nuget

- run: dotnet tool install --tool-path . sign --version 0.9.1-beta.23530.1
- run: dotnet tool install --tool-path . sign --version 0.9.1-beta.24170.3

- run: >
./sign code azure-key-vault
Expand Down
4 changes: 2 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>
<PropertyGroup>
<ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<!--<TargetFrameworks Condition=" '$(ContinuousIntegrationBuild)' == 'true' ">$(TargetFrameworks);net9.0</TargetFrameworks>-->
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks Condition="'$(DOCFX_PREVIEW_BUILD)' == 'true'">net8.0;net9.0</TargetFrameworks>
<LangVersion>Preview</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ We welcome code contributions through pull requests, issues tagged as **[`help-w
### Prerequisites

- Install [Visual Studio 2022 (Community or higher)](https://www.visualstudio.com/) and make sure you have the latest updates.
- Install [.NET SDK](https://dotnet.microsoft.com/download/dotnet) 6.x, 7.x and 8.x.
- Install [.NET SDK](https://dotnet.microsoft.com/download/dotnet) 6.x and 8.x.
- Install NodeJS (20.x.x).

### Build and Test
Expand Down