Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Skip unstable SVG content check that returned from PlantUML Online Server #9858

Merged
merged 4 commits into from
Apr 11, 2024
Merged

chore: Skip unstable SVG content check that returned from PlantUML Online Server #9858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95381cb
chore: skip unstable plantuml test
filzrev Apr 9, 2024
fa8ce9d
Merge branch 'main' into chore-skip-unstablle-plantuml-test
filzrev Apr 11, 2024
ac73209
chore: change svg content assertion logics
filzrev Apr 11, 2024
ab601da
Merge branch 'main' into chore-skip-unstablle-plantuml-test
filzrev Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/Docfx.MarkdigEngine.Extensions.Tests/PlantUmlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using FluentAssertions;
using Xunit;

namespace Docfx.MarkdigEngine.Tests;
Expand All @@ -18,14 +19,13 @@ public void TestRenderSvg_SequenceDiagram()
```
""";

var expected = """
<div class="lang-plantUml"><?xml version="1.0" encoding="us-ascii" standalone="no"?><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" contentStyleType="text/css" height="120px" preserveAspectRatio="none" style="width:113px;height:120px;background:#FFFFFF;" version="1.1" viewBox="0 0 113 120" width="113px" zoomAndPan="magnify"><defs/><g><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5.0,5.0;" x1="26" x2="26" y1="36.2969" y2="85.4297"/><line style="stroke:#181818;stroke-width:0.5;stroke-dasharray:5.0,5.0;" x1="82" x2="82" y1="36.2969" y2="85.4297"/><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="43" x="5" y="5"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="29" x="12" y="24.9951">Bob</text><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="43" x="5" y="84.4297"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="29" x="12" y="104.4248">Bob</text><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="49" x="58" y="5"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="35" x="65" y="24.9951">Alice</text><rect fill="#E2E2F0" height="30.2969" rx="2.5" ry="2.5" style="stroke:#181818;stroke-width:0.5;" width="49" x="58" y="84.4297"/><text fill="#000000" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="35" x="65" y="104.4248">Alice</text><polygon fill="#181818" points="70.5,63.4297,80.5,67.4297,70.5,71.4297,74.5,67.4297" style="stroke:#181818;stroke-width:1.0;"/><line style="stroke:#181818;stroke-width:1.0;" x1="26.5" x2="76.5" y1="67.4297" y2="67.4297"/><text fill="#000000" font-family="sans-serif" font-size="13" lengthAdjust="spacing" textLength="30" x="33.5" y="62.3638">hello</text><!--SRC=[SyfFKj2rKt3CoKnELR1Io4ZDoSa70000]--></g></svg></div>
""";

TestUtility.VerifyMarkup(source, expected, plantUml: new()
var result = TestUtility.VerifyMarkup(source, html: null, plantUml: new()
{
OutputFormat = PlantUml.Net.OutputFormat.Svg,
RemoteUrl = "https://www.plantuml.com/plantuml",
});
}).TrimEnd();

result.Should().StartWith("""<div class="lang-plantUml"><?xml version="1.0" encoding="us-ascii" standalone="no"?><svg""");
result.Should().EndWith("""hello</text><!--SRC=[SyfFKj2rKt3CoKnELR1Io4ZDoSa70000]--></g></svg></div>""");
}
}
3 changes: 2 additions & 1 deletion test/Docfx.MarkdigEngine.Extensions.Tests/TestUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Docfx.MarkdigEngine.Tests;

public static class TestUtility
{
public static void VerifyMarkup(
public static string VerifyMarkup(
string markdown,
string html,
string[] errors = null,
Expand Down Expand Up @@ -68,6 +68,7 @@ public static void VerifyMarkup(
{
Assert.Equal(dependencies.OrderBy(_ => _), actualDependencies.OrderBy(_ => _));
}
return actualHtml;
}

MarkdownContext.LogActionDelegate Log(string level)
Expand Down