Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new line in mref title #9633

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: new line in mref title #9633

merged 2 commits into from
Jan 24, 2024

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jan 21, 2024

fixes #9613

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad6db16) 74.31% compared to head (349adf6) 74.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9633   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files         536      536           
  Lines       23173    23173           
  Branches     4054     4054           
=======================================
  Hits        17220    17220           
  Misses       4851     4851           
  Partials     1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Jan 21, 2024
@yufeih yufeih reopened this Jan 21, 2024
@yufeih yufeih merged commit e2f78e9 into main Jan 24, 2024
8 checks passed
@yufeih yufeih deleted the title-nl branch January 24, 2024 04:17
@Thraka
Copy link

Thraka commented Jan 25, 2024

@yufeih Could you explain how this fixed the problem? Before I filed the bug I tried my hardest to understand what was causing it and fix it myself 😁 but I don't see how this impacts the <meta tag??

@yufeih
Copy link
Contributor Author

yufeih commented Jan 27, 2024

Here the template uses {{>partials/title}} for .NET API reference pages.

@Thraka
Copy link

Thraka commented Jan 28, 2024

Yes I see it now! Thanks!

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* fix: new line in mref title

* test(snapshot): update snapshots 9473d68 for ubuntu-latest

---------

Co-authored-by: yufeih <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] API articles titles have a new line in them when _apptitle is used
2 participants