Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to Jint 3.0.0-beta-2059 #9583

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Jan 5, 2024

With latest release we made some API changes for consistency and clearer type names. This requires some code changes in consuming code and here I'm offering them to you, free of charge.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0d56f79) 74.36% compared to head (0e999de) 74.36%.

Files Patch % Lines
...ocessors/Preprocessors/TemplateJintPreprocessor.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9583   +/-   ##
=======================================
  Coverage   74.36%   74.36%           
=======================================
  Files         536      536           
  Lines       23162    23162           
  Branches     4048     4048           
=======================================
  Hits        17224    17224           
  Misses       4838     4838           
  Partials     1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lahma
Copy link
Contributor Author

lahma commented Jan 5, 2024

CI failures seem unrelated, maybe..

@lahma lahma marked this pull request as ready for review January 5, 2024 15:55
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lahma !

@yufeih yufeih merged commit a22d5ac into dotnet:main Jan 6, 2024
6 of 8 checks passed
@lahma lahma deleted the jint-3.0.0-beta-2059 branch January 6, 2024 07:28
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jan 12, 2024
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants