Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hide the Docfx templates folder from VS project tree #9554

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jwfx
Copy link
Contributor

@jwfx jwfx commented Dec 20, 2023

Hide the Docfx templates folder from VS project tree, via docfx.app.props file as workaround until the issue is resolved from NuGet side.

Credits for workaround: NuGet/Home#4856 (comment)

Fixes #9549

@jwfx jwfx force-pushed the exclude-templates-project-tree branch from cc5c4d4 to 7017ed7 Compare December 20, 2023 08:55
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Dec 20, 2023
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jwfx , looks great!

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abea342) 71.36% compared to head (7017ed7) 71.35%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9554      +/-   ##
==========================================
- Coverage   71.36%   71.35%   -0.02%     
==========================================
  Files         558      558              
  Lines       24032    24032              
  Branches     4176     4176              
==========================================
- Hits        17151    17148       -3     
- Misses       5782     5784       +2     
- Partials     1099     1100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 51026a8 into dotnet:main Dec 20, 2023
8 checks passed
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add MSBuild option to hide templates from VS project tree
2 participants