Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: clean up public API contract #9537

Closed
wants to merge 9 commits into from
Closed

BREAKING CHANGE: clean up public API contract #9537

wants to merge 9 commits into from

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 18, 2023

Reduce public API surface area of for

  • Docfx.YamlSerialization
  • Docfx.Glob
  • Docfx.Build.Common
  • Docfx.Common

#8944

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Dec 18, 2023
@yufeih yufeih closed this Dec 18, 2023
@yufeih yufeih reopened this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2dd7f20) 71.36% compared to head (4dd1988) 71.39%.

❗ Current head 4dd1988 differs from pull request most recent head 7336e5a. Consider uploading reports for the commit 7336e5a to get more accurate results

Files Patch % Lines
src/Docfx.YamlSerialization/YamlSerializer.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9537      +/-   ##
==========================================
+ Coverage   71.36%   71.39%   +0.03%     
==========================================
  Files         558      558              
  Lines       24024    24006      -18     
  Branches     4173     4169       -4     
==========================================
- Hits        17144    17139       -5     
+ Misses       5782     5771      -11     
+ Partials     1098     1096       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Dec 18, 2023
@yufeih yufeih reopened this Dec 18, 2023
@yufeih yufeih changed the title BREAKING CHANGE: clean up Docfx.YamlSerialization public API contract BREAKING CHANGE: clean up public API contract Dec 18, 2023
fal

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant