Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop name.vb from toc output #9530

Merged
merged 7 commits into from
Dec 15, 2023
Merged

chore: drop name.vb from toc output #9530

merged 7 commits into from
Dec 15, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 14, 2023

name.vb in toc.json output was designed to support dynamic language switching, which was never completely implemented. This PR drops support of name.vb as an output for TOC to fix unstable name. output as seen in #9528

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Dec 14, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb7ebc6) 71.34% compared to head (91e6667) 71.37%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9530      +/-   ##
==========================================
+ Coverage   71.34%   71.37%   +0.03%     
==========================================
  Files         558      558              
  Lines       24048    24024      -24     
  Branches     4182     4173       -9     
==========================================
- Hits        17156    17147       -9     
+ Misses       5793     5780      -13     
+ Partials     1099     1097       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Dec 15, 2023
@yufeih yufeih reopened this Dec 15, 2023
@yufeih yufeih merged commit 84b7afb into main Dec 15, 2023
7 checks passed
@yufeih yufeih deleted the notocdevlang branch December 15, 2023 03:48
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* chore: drop name.vb from toc output

* test(snapshot): update snapshots 4602f28 for ubuntu-latest

* test(snapshot): update snapshots 4602f28 for windows-latest

* drop name.vb in split member pages

* test(snapshot): update snapshots c366226 for ubuntu-latest

* test(snapshot): update snapshots c366226 for windows-latest

---------

Co-authored-by: yufeih <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant