FIX: Docset Pdf call terminating early #9493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9493 +/- ##
=======================================
Coverage 71.33% 71.34%
=======================================
Files 558 558
Lines 24043 24048 +5
Branches 4184 4182 -2
=======================================
+ Hits 17151 17156 +5
Misses 5793 5793
Partials 1099 1099 ☔ View full report in Codecov by Sentry. |
yufeih
approved these changes
Dec 1, 2023
yufeih
added
the
bug-fix
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
* add logging around toc search * fix exec not waiting for async pdf builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where Docset.Pdf was dropping out before the PDF generation was actually running because the action wasn't blocking on the method call.