-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle log severity using rules config #9460
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9460 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 561 561
Lines 23980 23987 +7
Branches 4170 4173 +3
=======================================
+ Hits 17108 17113 +5
- Misses 5778 5779 +1
- Partials 1094 1095 +1 ☔ View full report in Codecov by Sentry. |
@yufeih Did you ever consider a way to identify and then ignore docfx warnings individually? |
Let's see if I understand your question: this change would allow individual warnings to be ignored at the error code level, similar to CS0000/Diagnostics ID (although not all warnings/errors have a code today). Are you looking for suppressing levels at an even more granular level such as |
I think as a first step it would be cool if all warnings/errors that docfx can produce would have an ID and the severity of that warning can be configure globally for a build (e.g. in docfx.json). Being able to do control the warnings occurrences individually similar to |
That make sense and is exactly what this PR is aiming for. |
* feat: toggle log severity using rules config * Update docfx-json-reference.md * add more warning codes in metadata command --------- Co-authored-by: Yufei Huang <[email protected]>
Enables toggle log severity based on log code in
docfx.json
usingrules
such as:Adds the following error code for
metadata
command:InvalidAssemblyReference
InvalidCref
InvalidXmlComment
CodeNotFound
This does not fix #9459 but provides a way to suppress warnings no per error code.