Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add page number to PDF pages #9359

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: add page number to PDF pages #9359

merged 1 commit into from
Oct 31, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Oct 31, 2023

#9343

Fixes #2003

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Docfx.App/PdfBuilder.cs 6.51% <0.00%> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yufeih yufeih merged commit ab26748 into main Oct 31, 2023
7 checks passed
@yufeih yufeih deleted the pdfpn branch October 31, 2023 03:02
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
feat: add page number to PDF pages (dotnet#9359)
d279794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF: add support for footers and TOC with page numbers
1 participant
@yufeih