Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused code #9164

Merged
merged 1 commit into from
Sep 4, 2023
Merged

chore: Remove unused code #9164

merged 1 commit into from
Sep 4, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Sep 2, 2023 •
edited
Loading

What's included in this PR

  • Remove unused code from DocumentProcessors

It seems these code are not used. and it can be replaced with JsonUtility's methods.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
...ConceptualDocuments/ConceptualDocumentProcessor.cs ø
...agedReference/ManagedReferenceDocumentProcessor.cs ø
...uild.SchemaDriven/SchemaDrivenDocumentProcessor.cs ø

📢 Thoughts on this report? Let us know!.

yufeih
yufeih approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@yufeih yufeih merged commit 0e6c556 into dotnet:main Sep 4, 2023
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Sep 4, 2023
@p-linnane p-linnane mentioned this pull request Sep 4, 2023
Merged
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@filzrev @p-kostov
chore: Remove unused code (dotnet#9164)
0f6d889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filzrev @yufeih