Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support language attribute on C# documentation comment #9159

Merged
merged 2 commits into from
Sep 2, 2023
Merged

feat: support language attribute on C# documentation comment #9159

merged 2 commits into from
Sep 2, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Sep 1, 2023

Supports language attribute on <code> element in C# XML documentation comment. <code> elements uses csharp as the default language id, this can be overridden by the language attribute:

<code language="xml">
<![CDATA[
 <chart:Chart>
  <!-- ... Eliminated for simplicity-->
 </chart:Chart>
]]>
</code>

fixes #9156

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/Docfx.Dotnet/Parsers/XmlComment.cs 100.00%

📢 Thoughts on this report? Let us know!.

@yufeih yufeih closed this Sep 1, 2023
@yufeih yufeih reopened this Sep 1, 2023
@filzrev filzrev mentioned this pull request Sep 1, 2023
Closed
@yufeih yufeih merged commit 463b3f7 into main Sep 2, 2023
@yufeih yufeih deleted the lang branch September 2, 2023 00:57
@p-linnane p-linnane mentioned this pull request Sep 4, 2023
Merged
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
feat: support language attribute on C# documentation comment (dotnet#…
532d91a 
…9159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support code element's language attribute when parsing XML comment
1 participant
@yufeih