-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor docfx command related code #9140
chore: Refactor docfx command related code #9140
Conversation
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
Thanks for putting this together. I need some time to examine the public API surface and may likely tweak it a little bit. |
Here are some of the public API guidelines for the config objects I have in mind:
|
25ddd3d
to
8d70d47
Compare
8d70d47
to
4a3f37d
Compare
Thank you for your explanations about public API guidelines. So I decided to use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @filzrev
What's included in this PR
Change docfx command related API/Models from internal to public.Remove<InternalsVisibleTo Include="docfx" />
settingsMove constant string
docfx.json
definition toDocfx.DataContracts.Common
project.Add
RunMetadata.cs
wrapper to useDotnetApiCatalog
API.Background
As described at #8872.
Current
Docfx.App
package expose limited API set only.By this PR,
Docfx.App
user can consume same APIs that is used bydocfx.exe
.